[webkit-changes] [WebKit/WebKit] 176591: Expose a 'category' for Web Preferences

Brent Fulgham noreply at github.com
Thu Feb 16 21:26:00 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 176591df93a53b8c551157e6c735e8e24d3fd1c1
      https://github.com/WebKit/WebKit/commit/176591df93a53b8c551157e6c735e8e24d3fd1c1
  Author: Brent Fulgham <bfulgham at apple.com>
  Date:   2023-02-16 (Thu, 16 Feb 2023)

  Changed paths:
    M Source/WTF/Scripts/GeneratePreferences.rb
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebCore/Scripts/GenerateSettings.rb
    M Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesFeatures.cpp.erb
    M Source/WebKit/UIProcess/API/APIFeature.cpp
    M Source/WebKit/UIProcess/API/APIFeature.h
    M Source/WebKit/UIProcess/API/APIFeatureStatus.h
    M Source/WebKit/UIProcess/API/Cocoa/_WKFeature.h
    M Source/WebKit/UIProcess/API/Cocoa/_WKFeature.mm
    M Source/WebKitLegacy/mac/Scripts/PreferencesTemplates/WebPreferencesExperimentalFeatures.mm.erb
    M Source/WebKitLegacy/mac/Scripts/PreferencesTemplates/WebPreferencesInternalFeatures.mm.erb
    M Source/WebKitLegacy/mac/WebView/WebFeature.h
    M Source/WebKitLegacy/mac/WebView/WebFeature.m
    M Source/WebKitLegacy/mac/WebView/WebFeatureInternal.h

  Log Message:
  -----------
  Expose a 'category' for Web Preferences
https://bugs.webkit.org/show_bug.cgi?id=252093
<rdar://104962882>

Reviewed by Patrick Angle.

Add a new 'category' field to our preference definitions that can be used to provide context
to the User Interface for applications like Safari so that we can easily present the features
in the clearest way.

* Source/WTF/Scripts/GeneratePreferences.rb:
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/Scripts/GenerateSettings.rb:
* Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesFeatures.cpp.erb:
* Source/WebKit/UIProcess/API/APIFeature.cpp
(API::Feature::create): Add new argument.
(API::Feature::Feature): Ditto.
* Source/WebKit/UIProcess/API/APIFeature.h:
* Source/WebKit/UIProcess/API/APIFeatureStatus.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKFeature.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKFeature.mm:
(-[_WKFeature category]):
* Source/WebKitLegacy/mac/Scripts/PreferencesTemplates/WebPreferencesExperimentalFeatures.mm.erb:
* Source/WebKitLegacy/mac/Scripts/PreferencesTemplates/WebPreferencesInternalFeatures.mm.erb:
* Source/WebKitLegacy/mac/WebView/WebFeature.h:
* Source/WebKitLegacy/mac/WebView/WebFeature.m:
(-[WebFeature initWithKey:preferenceKey:name:status:category:details:defaultValue:hidden:]): Added.
(-[WebFeature initWithKey:preferenceKey:name:status:details:defaultValue:hidden:]): Deleted.
* Source/WebKitLegacy/mac/WebView/WebFeatureInternal.h:

Canonical link: https://commits.webkit.org/260420@main




More information about the webkit-changes mailing list