[webkit-changes] [WebKit/WebKit] d5a126: [WebGPU] popErrorScope causes an IPC assertion

mwyrzykowski noreply at github.com
Thu Feb 16 18:41:47 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d5a1264b45a7b6e3e77c6d0017090a965e63ae91
      https://github.com/WebKit/WebKit/commit/d5a1264b45a7b6e3e77c6d0017090a965e63ae91
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2023-02-16 (Thu, 16 Feb 2023)

  Changed paths:
    M LayoutTests/http/tests/webgpu/webgpu/api/operation/adapter/requestAdapter-expected.txt
    M LayoutTests/platform/mac/TestExpectations
    M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.messages.in
    M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.cpp
    M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.h

  Log Message:
  -----------
  [WebGPU] popErrorScope causes an IPC assertion
https://bugs.webkit.org/show_bug.cgi?id=251666
<radar://104993240>

Reviewed by Myles C. Maxfield.

GPUDevice.popErrorScope is supposed to be asynchronous, so use sendWithAsyncReply
instead of sendSync.

* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.messages.in:
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.cpp:
(WebKit::WebGPU::RemoteDeviceProxy::popErrorScope):
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.h:

Canonical link: https://commits.webkit.org/260413@main




More information about the webkit-changes mailing list