[webkit-changes] [WebKit/WebKit] 6db3bf: REGRESSION(259626 at main): Fullscreen and PiP button...

Eric Carlson noreply at github.com
Thu Feb 16 15:39:41 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6db3bff657b6e0d735bb699a5a4d64d0f7a2141d
      https://github.com/WebKit/WebKit/commit/6db3bff657b6e0d735bb699a5a4d64d0f7a2141d
  Author: Eric Carlson <eric.carlson at apple.com>
  Date:   2023-02-16 (Thu, 16 Feb 2023)

  Changed paths:
    M Source/WebCore/html/HTMLMediaElement.cpp

  Log Message:
  -----------
  REGRESSION(259626 at main): Fullscreen and PiP buttons don't work in a media document
https://bugs.webkit.org/show_bug.cgi?id=252417
rdar://105469592

Reviewed by Jer Noble.

* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::enterFullscreen): Consume a transient activation if fullscreen
is required, but don't reject is there is no activation because this method can not be
called unless the element is allowed to enter fullscreen.

Canonical link: https://commits.webkit.org/260401@main




More information about the webkit-changes mailing list