[webkit-changes] [WebKit/WebKit] 72fbef: css/css-transitions/changing-while-transition-004....

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 72fbef8329886aa121db84301c056ce9fdc0609d
      https://github.com/WebKit/WebKit/commit/72fbef8329886aa121db84301c056ce9fdc0609d
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2023-02-16 (Thu, 16 Feb 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/changing-while-transition-004-expected.txt
    M Source/WebCore/style/Styleable.cpp

  Log Message:
  -----------
  css/css-transitions/changing-while-transition-004.html is a unique failure
https://bugs.webkit.org/show_bug.cgi?id=235132
rdar://87785199

Reviewed by Dean Jackson.

We used to assume that not finding an Animation object matching the CSS property being considered for transitions
meant that that property was not found in the transition-property value list. However, the initial value for
transition-property is `all` and means that any CSS property matches. So we must distinguish between
that and having a matching Animation object to correctly implement the "starting a transition" procedure.

* LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/changing-while-transition-004-expected.txt:
* Source/WebCore/style/Styleable.cpp:
(WebCore::compileTransitionPropertiesInStyle):
(WebCore::updateCSSTransitionsForStyleableAndProperty):
(WebCore::transitionCombinedDuration): Deleted.

Canonical link: https://commits.webkit.org/260398@main