[webkit-changes] [WebKit/WebKit] 7caa16: Replace clearCachedCredentials with existing websi...

Sihui noreply at github.com
Thu Feb 16 13:58:42 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7caa16c96e775eb1a0116378d3ab72be1355ef0b
      https://github.com/WebKit/WebKit/commit/7caa16c96e775eb1a0116378d3ab72be1355ef0b
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2023-02-16 (Thu, 16 Feb 2023)

  Changed paths:
    M Source/WebKit/NetworkProcess/NetworkProcess.cpp
    M Source/WebKit/NetworkProcess/NetworkProcess.h
    M Source/WebKit/NetworkProcess/NetworkProcess.messages.in
    M Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp
    M Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.h
    M Source/WebKit/UIProcess/WebProcessPool.h
    M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
    M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h
    M Tools/WebKitTestRunner/TestController.cpp

  Log Message:
  -----------
  Replace clearCachedCredentials with existing website data removal function
https://bugs.webkit.org/show_bug.cgi?id=252340
rdar://105512071

Reviewed by Alex Christensen.

clearCachedCredentials() was introduced to clear credentials between tests, and the C API is only used in test nowadays.
As we have a more generic way ask network process to clear some type of data (NetworkProcess::deleteWebsiteData), we
could use that for credentials and don't need a separate clearCachedCredentials() any more.

* Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::clearCachedCredentials): Deleted.
* Source/WebKit/NetworkProcess/NetworkProcess.h:
* Source/WebKit/NetworkProcess/NetworkProcess.messages.in:
* Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp:
(WKWebsiteDataStoreClearStorage):
(WKWebsiteDataStoreClearCachedCredentials): Deleted.
* Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.h:
* Source/WebKit/UIProcess/WebProcessPool.h:
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::clearCachedCredentials): Deleted.
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:
* Tools/WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):

Canonical link: https://commits.webkit.org/260395@main




More information about the webkit-changes mailing list