[webkit-changes] [WebKit/WebKit] fcdce8: [css-transitions] `transition-property: all` does ...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fcdce8ff40bbdf656f8d6d9247e9c94538a9dc2e
      https://github.com/WebKit/WebKit/commit/fcdce8ff40bbdf656f8d6d9247e9c94538a9dc2e
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2023-02-16 (Thu, 16 Feb 2023)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/animation/custom-property-transition-property-all-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/animation/custom-property-transition-property-all.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/resources/utils.js
    M Source/WebCore/style/Styleable.cpp

  Log Message:
  -----------
  [css-transitions] `transition-property: all` does not apply to custom properties
https://bugs.webkit.org/show_bug.cgi?id=252312

Reviewed by Antti Koivisto.

When setting `transition-property: all`, which also happens to be that property's initial value,
we would correctly consider all properties known within WebCore as a CSSPropertyID, but we would
fail to consider registered custom properties that could otherwise be interpolated.

We now iterate through all custom properties in both the before-change and after-change styles
to gather custom properties that can be interpolated (ie. either a SyntaxValue or SyntaxValueList)
and run the transition update logic on those.

* LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/animation/custom-property-transition-property-all-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/animation/custom-property-transition-property-all.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/resources/utils.js:
* Source/WebCore/style/Styleable.cpp:
(WebCore::Styleable::updateCSSTransitions const):

Canonical link: https://commits.webkit.org/260384@main