[webkit-changes] [WebKit/WebKit] b51fc8: PlaybackSessionManager and VideoFullscreenManager ...

Ryosuke Niwa noreply at github.com
Thu Feb 16 10:59:42 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b51fc8ba75c9d04015a051e0c4ab8dd854a49e9c
      https://github.com/WebKit/WebKit/commit/b51fc8ba75c9d04015a051e0c4ab8dd854a49e9c
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2023-02-16 (Thu, 16 Feb 2023)

  Changed paths:
    M Source/WebKit/WebProcess/cocoa/PlaybackSessionManager.h
    M Source/WebKit/WebProcess/cocoa/PlaybackSessionManager.mm
    M Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.h
    M Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm

  Log Message:
  -----------
  PlaybackSessionManager and VideoFullscreenManager should use WeakPtr and WeakHashMap
https://bugs.webkit.org/show_bug.cgi?id=252348

Reviewed by Chris Dumez.

Deployed WeakPtr and WeakHashMap in PlaybackSessionManager and VideoFullscreenManager.

* Source/WebKit/WebProcess/cocoa/PlaybackSessionManager.h:
* Source/WebKit/WebProcess/cocoa/PlaybackSessionManager.mm:
(WebKit::PlaybackSessionManager::PlaybackSessionManager):
(WebKit::PlaybackSessionManager::removeContext):
(WebKit::PlaybackSessionManager::setUpPlaybackControlsManager):
(WebKit::PlaybackSessionManager::contextIdForMediaElement):
* Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.h:
* Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm:
(WebKit::VideoFullscreenManager::removeContext):
(WebKit::VideoFullscreenManager::enterVideoFullscreenForVideoElement):
(WebKit::VideoFullscreenManager::exitVideoFullscreenForVideoElement):
(WebKit::VideoFullscreenManager::exitVideoFullscreenToModeWithoutAnimation):

Canonical link: https://commits.webkit.org/260382@main




More information about the webkit-changes mailing list