[webkit-changes] [WebKit/WebKit] 3cf4b3: REGRESSION (255598 at main): checkbox overlaps Log In...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3cf4b3198445cc3e87c2e7feff88514f33a6b1e9
      https://github.com/WebKit/WebKit/commit/3cf4b3198445cc3e87c2e7feff88514f33a6b1e9
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-02-16 (Thu, 16 Feb 2023)

  Changed paths:
    A LayoutTests/fast/inline/out-of-flow-inline-with-previous-next-margin-expected.html
    A LayoutTests/fast/inline/out-of-flow-inline-with-previous-next-margin.html
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp

  Log Message:
  -----------
  REGRESSION (255598 at main): checkbox overlaps Log In button on ally.com
https://bugs.webkit.org/show_bug.cgi?id=252379
<rdar://104303475>

Reviewed by Antti Koivisto.

While display boxes are positioned based on margin boxes, the left/right side of a display box
do not include these margins.

e.g.

[display box #1]<- 100px margin ->[display box #2]
   width: 50px                        width: 50px
  margin-right: 100px;

display box #1's right: 50px
display box #2's left: 150px

This patch makes sure when we place an out-of-flow box next to display box #1, we put it at 150px and not at 50px.

* LayoutTests/fast/inline/out-of-flow-inline-with-previous-next-margin-expected.html: Added.
* LayoutTests/fast/inline/out-of-flow-inline-with-previous-next-margin.html: Added.
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp:
(WebCore::Layout::InlineFormattingGeometry::staticPositionForOutOfFlowInlineLevelBox const):

Canonical link: https://commits.webkit.org/260380@main