[webkit-changes] [WebKit/WebKit] 587cb6: [GTK] Criticals from webkitOptionMenuSetEvent when...

[Michael Catanzaro]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 587cb602ebdded6401ebc269b51028b6f414ca42
      https://github.com/WebKit/WebKit/commit/587cb602ebdded6401ebc269b51028b6f414ca42
  Author: Michael Catanzaro <mcatanzaro at redhat.com>
  Date:   2023-02-16 (Thu, 16 Feb 2023)

  Changed paths:
    M Source/WebKit/Shared/API/glib/WebKitContextMenu.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitOptionMenu.cpp
    M Source/WebKit/UIProcess/gtk/WebContextMenuProxyGtk.cpp

  Log Message:
  -----------
  [GTK] Criticals from webkitOptionMenuSetEvent when opening any combo box
https://bugs.webkit.org/show_bug.cgi?id=252264

Reviewed by Adrian Perez de Castro.

WebKitOptionMenu.cpp does not #include <WebCore/GRefPtrGtk.h> and
therefore the template specialization for GdkEvent is missing, so the
GRefPtr treats it as a GObject even though it is not. This is really
dangerous and we need to find a better way to prevent it from happening,
but for now, add missing #includes here and in a couple other places
where it looks like they might be needed.

* Source/WebKit/Shared/API/glib/WebKitContextMenu.cpp:
* Source/WebKit/UIProcess/API/glib/WebKitOptionMenu.cpp:
* Source/WebKit/UIProcess/gtk/WebContextMenuProxyGtk.cpp:

Canonical link: https://commits.webkit.org/260374@main