[webkit-changes] [WebKit/WebKit] 9605dc: Check for fileSystemPath being non-null when addin...

Chirag Shah noreply at github.com
Wed Feb 15 22:00:03 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9605dc730f989f14ed646967fd70ab807d54ab36
      https://github.com/WebKit/WebKit/commit/9605dc730f989f14ed646967fd70ab807d54ab36
  Author: Chirag M Shah <chirag_m_shah at apple.com>
  Date:   2023-02-15 (Wed, 15 Feb 2023)

  Changed paths:
    A LayoutTests/fast/history/add-file-with-invalid-utf8-crash-expected.txt
    A LayoutTests/fast/history/add-file-with-invalid-utf8-crash.html
    M Source/WebKit/UIProcess/WebProcessProxy.cpp

  Log Message:
  -----------
  Check for fileSystemPath being non-null when adding to set
https://bugs.webkit.org/show_bug.cgi?id=252341
rdar://99575855

Reviewed by Chris Dumez.

This change fixes the crash in the UI process when the fileSystemPath is
not a valid UTF-8.

* LayoutTests/fast/history/add-file-with-invalid-utf8-crash-expected.txt: Added.
* LayoutTests/fast/history/add-file-with-invalid-utf8-crash.html: Added.
* Source/WebKit/UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::addPreviouslyApprovedFileURL):
(WebKit::WebProcessProxy::wasPreviouslyApprovedFileURL const):

Canonical link: https://commits.webkit.org/260351@main




More information about the webkit-changes mailing list