[webkit-changes] [WebKit/WebKit] c58c08: Save recent searches with name attribute

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c58c088437779ba48d081ebc83242e3b71f34ca7
      https://github.com/WebKit/WebKit/commit/c58c088437779ba48d081ebc83242e3b71f34ca7
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2023-02-15 (Wed, 15 Feb 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    A LayoutTests/fast/forms/search/search-recent-searches-expected.txt
    A LayoutTests/fast/forms/search/search-recent-searches.html
    M LayoutTests/imported/blink/fast/forms/search-popup-crasher.html
    M LayoutTests/platform/mac/TestExpectations
    M Source/WebCore/platform/cocoa/SearchPopupMenuCocoa.mm
    M Source/WebCore/rendering/RenderSearchField.cpp
    M Source/WebCore/rendering/RenderSearchField.h
    M Source/WebCore/testing/Internals.cpp
    M Source/WebCore/testing/Internals.h
    M Source/WebCore/testing/Internals.idl

  Log Message:
  -----------
  Save recent searches with name attribute
https://bugs.webkit.org/show_bug.cgi?id=252139
rdar://105369635

Reviewed by Darin Adler.

autosave attribute is non-standard and is not tracked in any active proposal, so we should stop using it to decide
whether a search item can be saved. This patch changes the logic to use name attribute to match Chrome and Firefox's
behavior.

New test: fast/forms/search/search-recent-searches.html

* LayoutTests/TestExpectations:
* LayoutTests/fast/forms/search/search-recent-searches-expected.txt: Added.
* LayoutTests/fast/forms/search/search-recent-searches.html: Added.
* LayoutTests/imported/blink/fast/forms/search-popup-crasher.html:
* LayoutTests/platform/mac/TestExpectations:
* Source/WebCore/platform/cocoa/SearchPopupMenuCocoa.mm:
(WebCore::saveRecentSearches):
* Source/WebCore/rendering/RenderSearchField.cpp:
(WebCore::RenderSearchField::recentSearches):
(WebCore::RenderSearchField::autosaveName const):
* Source/WebCore/rendering/RenderSearchField.h:
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::recentSearches):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:

Canonical link: https://commits.webkit.org/260316@main