[webkit-changes] [WebKit/WebKit] 9b178b: [IFC] LineBoxes do not need to outlive line layout.

Alan Baradlay noreply at github.com
Wed Feb 15 07:48:58 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9b178ba3eda0c15772a8185e709ebd479af757c9
      https://github.com/WebKit/WebKit/commit/9b178ba3eda0c15772a8185e709ebd479af757c9
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-02-15 (Wed, 15 Feb 2023)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingState.h

  Log Message:
  -----------
  [IFC] LineBoxes do not need to outlive line layout.
https://bugs.webkit.org/show_bug.cgi?id=252280

Reviewed by Antti Koivisto.

They are input to InlineDisplayLineBuilder/InlineDisplayContentBuilder, but we never reuse them in subsequent layouts.

* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::createDisplayContentForLine):
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingState.h:
(WebCore::Layout::InlineFormattingState::clearLineAndBoxes):
(WebCore::Layout::InlineFormattingState::shrinkToFit):
(WebCore::Layout::InlineFormattingState::lineBoxes const): Deleted.
(WebCore::Layout::InlineFormattingState::addLineBox): Deleted.

Canonical link: https://commits.webkit.org/260309@main




More information about the webkit-changes mailing list