[webkit-changes] [WebKit/WebKit] adab15: [svg] marker properties should allow any URI

Antoine Quint noreply at github.com
Tue Feb 14 23:02:46 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: adab1550880a6b4d78ec26f85fbfd3105e34b60b
      https://github.com/WebKit/WebKit/commit/adab1550880a6b4d78ec26f85fbfd3105e34b60b
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2023-02-14 (Tue, 14 Feb 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/svg/painting/inheritance-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/svg/painting/parsing/marker-end-computed-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/svg/painting/parsing/marker-mid-computed-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/svg/painting/parsing/marker-start-computed-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt
    M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt
    M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt
    M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt
    R LayoutTests/svg/css/computed-style-url-serializing-expected.txt
    R LayoutTests/svg/css/computed-style-url-serializing.html
    M Source/WebCore/css/SVGCSSComputedStyleDeclaration.cpp
    M Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp
    M Source/WebCore/rendering/svg/SVGResources.cpp
    M Source/WebCore/style/StyleBuilderConverter.h

  Log Message:
  -----------
  [svg] marker properties should allow any URI
https://bugs.webkit.org/show_bug.cgi?id=252163

Reviewed by Said Abou-Hallawa.

Resolve the fragment of the URL passed to the marker properties at use time rather than at parse-time.

We remove a non-WPT test that was incorrect in its assumptions and testing functionality already covered
by WPT.

* LayoutTests/imported/w3c/web-platform-tests/svg/painting/inheritance-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/painting/parsing/marker-end-computed-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/painting/parsing/marker-mid-computed-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/painting/parsing/marker-start-computed-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:
* LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
* LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
* LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:
* LayoutTests/svg/css/computed-style-url-serializing-expected.txt: Removed.
* LayoutTests/svg/css/computed-style-url-serializing.html: Removed.
* Source/WebCore/css/SVGCSSComputedStyleDeclaration.cpp:
(WebCore::markerValue):
(WebCore::ComputedStyleExtractor::svgPropertyValue):
* Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::writeSVGPaintingFeatures):
* Source/WebCore/rendering/svg/SVGResources.cpp:
(WebCore::SVGResources::buildCachedResources):
* Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertSVGURIReference):

Canonical link: https://commits.webkit.org/260299@main




More information about the webkit-changes mailing list