[webkit-changes] [WebKit/WebKit] d706e8: Opt-in wide-layout attachment style using Shadow D...

[Gerald Squelart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d706e84b583afba61b95a266f34c5059df7e1d54
      https://github.com/WebKit/WebKit/commit/d706e84b583afba61b95a266f34c5059df7e1d54
  Author: Gerald Squelart <g_squelart at apple.com>
  Date:   2023-02-14 (Tue, 14 Feb 2023)

  Changed paths:
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebCore/CMakeLists.txt
    M Source/WebCore/DerivedSources-input.xcfilelist
    M Source/WebCore/DerivedSources.make
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/html/HTMLAttachmentElement.cpp
    M Source/WebCore/html/HTMLAttachmentElement.h
    A Source/WebCore/html/shadow/attachmentElementShadow.css
    M Source/WebCore/page/DragController.cpp
    M Source/WebCore/rendering/AttachmentLayout.mm
    M Source/WebCore/rendering/RenderAttachment.cpp
    M Source/WebCore/rendering/RenderAttachment.h
    M Source/WebCore/rendering/RenderThemeMac.mm

  Log Message:
  -----------
  Opt-in wide-layout attachment style using Shadow DOM tree
https://bugs.webkit.org/show_bug.cgi?id=251830
rdar://105103464

Reviewed by Aditya Keerthi.

Note that the modern attachment element uses an inner legacy attachment just to display the correct thumbnail or icon.

* Source/WebCore/html/HTMLAttachmentElement.cpp:
(WebCore::HTMLAttachmentElement::HTMLAttachmentElement):
(WebCore::HTMLAttachmentElement::ensureModernShadowRoot):
(WebCore::HTMLAttachmentElement::didAddUserAgentShadowRoot):
(WebCore::HTMLAttachmentElement::ensureModernShadowTree):
(WebCore::HTMLAttachmentElement::createElementRenderer): Deleted.
(WebCore::HTMLAttachmentElement::getAttachmentIdentifier): Deleted.
(WebCore::HTMLAttachmentElement::copyNonAttributePropertiesFromElement): Deleted.
(WebCore::HTMLAttachmentElement::archiveResourceURL): Deleted.
(WebCore::HTMLAttachmentElement::file const): Deleted.
(WebCore::HTMLAttachmentElement::blobURL const): Deleted.
(WebCore::HTMLAttachmentElement::setFile): Deleted.
(WebCore::HTMLAttachmentElement::insertedIntoAncestor): Deleted.
(WebCore::HTMLAttachmentElement::removedFromAncestor): Deleted.
(WebCore::HTMLAttachmentElement::ensureUniqueIdentifier): Deleted.
(WebCore::HTMLAttachmentElement::setUniqueIdentifier): Deleted.
(WebCore::HTMLAttachmentElement::enclosingImageElement const): Deleted.
(WebCore::HTMLAttachmentElement::parseAttribute): Deleted.
(WebCore::HTMLAttachmentElement::attachmentTitle const): Deleted.
(WebCore::HTMLAttachmentElement::attachmentTitleForDisplay const): Deleted.
(WebCore::HTMLAttachmentElement::attachmentType const): Deleted.
(WebCore::HTMLAttachmentElement::attachmentPath const): Deleted.
(WebCore::HTMLAttachmentElement::updateAttributes): Deleted.
(WebCore::mimeTypeIsSuitableForInlineImageAttachment): Deleted.
(WebCore::HTMLAttachmentElement::updateEnclosingImageWithData): Deleted.
(WebCore::HTMLAttachmentElement::updateThumbnail): Deleted.
(WebCore::HTMLAttachmentElement::updateIcon): Deleted.
(WebCore::HTMLAttachmentElement::requestIconWithSize const): Deleted.
(WebCore::HTMLAttachmentElement::childShouldCreateRenderer const): Deleted.
* Source/WebCore/html/HTMLAttachmentElement.h:
* Source/WebCore/rendering/AttachmentLayout.mm:
(WebCore::AttachmentLayout::layOutSubtitle):
(WebCore::AttachmentLayout::AttachmentLayout):

Canonical link: https://commits.webkit.org/260296@main