[webkit-changes] [WebKit/WebKit] 887ab6: REGRESSION: sreality.cz: pinch zooming on maps cau...
Richard Robinson
noreply at github.com
Tue Feb 14 21:42:53 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 887ab6d07a2756502d80ca21aa9eec1a0b2f7a76
https://github.com/WebKit/WebKit/commit/887ab6d07a2756502d80ca21aa9eec1a0b2f7a76
Author: Richard Robinson <richard_robinson2 at apple.com>
Date: 2023-02-14 (Tue, 14 Feb 2023)
Changed paths:
M Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
Log Message:
-----------
REGRESSION: sreality.cz: pinch zooming on maps causes tab to enter Tab Overview instead of interacting with map
https://bugs.webkit.org/show_bug.cgi?id=252023
rdar://104329203
Reviewed by Wenson Hsieh.
https://github.com/WebKit/WebKit/commit/b7a998fb59f59222ea76fe60141f38cfd2fc8cde introduced a new deferring gesture recognizer
for pan and pinch gestures. This had the conseequence of now letting Safari take
precedence over consuming these gestures rather than WebKit, causing the tab overview
to appear instead of zooming out of the map.
This PR adds a new private delegate method to `WKUIDelegate` that allows clients to specify
if a recognizer can be prevented by touch events. Then, if the gesture is also one that is
installed over the web view, the web view will take precedence.
* Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _gestureRecognizerCanBePreventedByTouchEvents:]):
(-[WKContentView deferringGestureRecognizer:shouldDeferOtherGestureRecognizer:]):
Canonical link: https://commits.webkit.org/260294@main
More information about the webkit-changes
mailing list