[webkit-changes] [WebKit/WebKit] ad421f: [Cocoa] We're unnecessarily asking the system whet...

Myles C. Maxfield noreply at github.com
Tue Feb 14 17:43:05 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ad421fc347f653b7d8926b6f33a93704d8a1bec1
      https://github.com/WebKit/WebKit/commit/ad421fc347f653b7d8926b6f33a93704d8a1bec1
  Author: Myles C. Maxfield <mmaxfield at apple.com>
  Date:   2023-02-14 (Tue, 14 Feb 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp
    M Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.h
    M Source/WebCore/platform/graphics/cocoa/FontFamilySpecificationCoreText.cpp

  Log Message:
  -----------
  [Cocoa] We're unnecessarily asking the system whether fonts we created are the system font or not
https://bugs.webkit.org/show_bug.cgi?id=252235
rdar://105442047

Reviewed by Alan Baradlay.

We create the fonts in the first place, so we already know whether or not they are
the system font or not. We should just remember the kind of font we created, rather
than having to call into Core Text for them to tell us.

* Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::preparePlatformFont):
(WebCore::fontDescriptorWithFamilySpecialCase):
(WebCore::fontWithFamily):
* Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.h:
* Source/WebCore/platform/graphics/cocoa/FontFamilySpecificationCoreText.cpp:
(WebCore::FontFamilySpecificationCoreText::fontRanges const):

Canonical link: https://commits.webkit.org/260289@main




More information about the webkit-changes mailing list