[webkit-changes] [WebKit/WebKit] 1eb5f6: Allow fetching or deleting data from custom persis...

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1eb5f68056d281580af0392b1d3cc1ee7c79b20e
      https://github.com/WebKit/WebKit/commit/1eb5f68056d281580af0392b1d3cc1ee7c79b20e
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2023-02-14 (Tue, 14 Feb 2023)

  Changed paths:
    M Source/WebCore/platform/network/CredentialStorage.cpp
    M Source/WebCore/platform/network/CredentialStorage.h
    M Source/WebCore/platform/network/mac/CredentialStorageMac.mm
    M Source/WebKit/NetworkProcess/NetworkProcess.cpp
    M Source/WebKit/NetworkProcess/NetworkSession.h
    M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h
    M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm

  Log Message:
  -----------
  Allow fetching or deleting data from custom persistent credential storage
https://bugs.webkit.org/show_bug.cgi?id=252126
rdar://105347284

Reviewed by Alex Christensen.

Since 260094 at main, WebsiteDataStore created with identifier uses separate credential storage from the shared (default)
one. Therefore, network process should look at correct credential storage when doing data fetch/deletion. For
WebsiteDataStore using shared credential storage, the current behavior is to only fetch/delete session-only credentials.
For custom (separate) credential storage, which should only be used by WebKit clients that has access to the
WebsiteDataStore, we could handle all credentails.

* Source/WebCore/platform/network/CredentialStorage.cpp:
(WebCore::CredentialStorage::originsWithSessionCredentials): Deleted.
(WebCore::CredentialStorage::removeSessionCredentialsWithOrigins): Deleted.
(WebCore::CredentialStorage::clearSessionCredentials): Deleted.
* Source/WebCore/platform/network/CredentialStorage.h:
* Source/WebCore/platform/network/mac/CredentialStorageMac.mm:
(WebCore::CredentialStorage::originsWithSessionCredentials): Deleted.
(WebCore::CredentialStorage::removeSessionCredentialsWithOrigins): Deleted.
(WebCore::CredentialStorage::clearSessionCredentials): Deleted.
* Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::fetchWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteDataForOrigins):
(WebKit::NetworkProcess::deleteAndRestrictWebsiteDataForRegistrableDomains):
(WebKit::NetworkProcess::registrableDomainsWithWebsiteData):
* Source/WebKit/NetworkProcess/NetworkSession.h:
* Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h:
* Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::originsWithCredentials):
(WebKit::NetworkSessionCocoa::removeCredentialsForOrigins):
(WebKit::NetworkSessionCocoa::clearCredentials):

Canonical link: https://commits.webkit.org/260276@main