[webkit-changes] [WebKit/WebKit] 59518f: Remove GenericCallback.h

Alex Christensen noreply at github.com
Tue Feb 14 12:54:10 PST 2023


  Branch: refs/heads/eng/Remove-GenericCallback-h
  Home:   https://github.com/WebKit/WebKit
  Commit: 59518f920b59d75fa37d3aeb504cf2100dd39f36
      https://github.com/WebKit/WebKit/commit/59518f920b59d75fa37d3aeb504cf2100dd39f36
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-02-14 (Tue, 14 Feb 2023)

  Changed paths:
    M Source/WebKit/Shared/ImageOptions.h
    M Source/WebKit/UIProcess/API/APIAttachment.h
    M Source/WebKit/UIProcess/API/APIIconLoadingClient.h
    M Source/WebKit/UIProcess/API/APIInspectorExtension.cpp
    M Source/WebKit/UIProcess/API/APIUIClient.h
    M Source/WebKit/UIProcess/API/C/WKPage.cpp
    M Source/WebKit/UIProcess/API/C/WKSpeechRecognitionPermissionCallback.cpp
    M Source/WebKit/UIProcess/API/Cocoa/NSAttributedString.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextController.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKErrorInternal.h
    M Source/WebKit/UIProcess/API/glib/WebKitContextMenuClient.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitFindController.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitInjectedBundleClient.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitNotificationProvider.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitWebResource.cpp
    M Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp
    M Source/WebKit/UIProcess/Cocoa/IconLoadingDelegate.mm
    M Source/WebKit/UIProcess/Cocoa/UIDelegate.h
    M Source/WebKit/UIProcess/Cocoa/UIDelegate.mm
    M Source/WebKit/UIProcess/DrawingAreaProxy.h
    R Source/WebKit/UIProcess/GenericCallback.h
    M Source/WebKit/UIProcess/Inspector/WebInspectorUIExtensionControllerProxy.cpp
    M Source/WebKit/UIProcess/Inspector/gtk/WebInspectorUIProxyGtk.cpp
    M Source/WebKit/UIProcess/Inspector/win/WebInspectorUIProxyWin.cpp
    M Source/WebKit/UIProcess/Notifications/WebNotificationManagerProxy.cpp
    R Source/WebKit/UIProcess/StatisticsRequest.cpp
    R Source/WebKit/UIProcess/StatisticsRequest.h
    M Source/WebKit/UIProcess/WebBackForwardList.h
    M Source/WebKit/UIProcess/WebContextClient.cpp
    M Source/WebKit/UIProcess/WebFrameProxy.h
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/UIProcess/WebProcessPool.cpp
    M Source/WebKit/UIProcess/WebProcessPool.h
    M Source/WebKit/UIProcess/mac/WKFullScreenWindowController.h
    M Source/WebKit/UIProcess/mac/WKTextFinderClient.mm
    M Source/WebKit/UIProcess/mac/WebViewImpl.mm
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.mm
    M Tools/WebKitTestRunner/TestController.cpp
    M Tools/WebKitTestRunner/TestController.h

  Log Message:
  -----------
  Remove GenericCallback.h
https://bugs.webkit.org/show_bug.cgi?id=252179
rdar://105406323

Reviewed by NOBODY (OOPS!).

Also remove some more dead code, including StatisticsRequest.cpp and
decidePolicyForSpeechRecognitionPermissionRequest which is not called.

* Source/WebKit/Shared/ImageOptions.h:
* Source/WebKit/UIProcess/API/APIAttachment.h:
* Source/WebKit/UIProcess/API/APIIconLoadingClient.h:
* Source/WebKit/UIProcess/API/APIInspectorExtension.cpp:
* Source/WebKit/UIProcess/API/APIUIClient.h:
(API::UIClient::decidePolicyForSpeechRecognitionPermissionRequest): Deleted.
* Source/WebKit/UIProcess/API/C/WKPage.cpp:
(WKPageSetPageUIClient):
* Source/WebKit/UIProcess/API/C/WKSpeechRecognitionPermissionCallback.cpp:
(WKSpeechRecognitionPermissionCallbackComplete):
* Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextController.mm:
* Source/WebKit/UIProcess/API/Cocoa/WKErrorInternal.h:
* Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:
* Source/WebKit/UIProcess/Cocoa/IconLoadingDelegate.mm:
* Source/WebKit/UIProcess/Cocoa/UIDelegate.h:
* Source/WebKit/UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::UIClient::decidePolicyForSpeechRecognitionPermissionRequest): Deleted.
* Source/WebKit/UIProcess/DrawingAreaProxy.h:
* Source/WebKit/UIProcess/GenericCallback.h: Removed.
* Source/WebKit/UIProcess/Inspector/WebInspectorUIExtensionControllerProxy.cpp:
* Source/WebKit/UIProcess/Notifications/WebNotificationManagerProxy.cpp:
* Source/WebKit/UIProcess/StatisticsRequest.cpp: Removed.
* Source/WebKit/UIProcess/StatisticsRequest.h: Removed.
* Source/WebKit/UIProcess/WebBackForwardList.h:
* Source/WebKit/UIProcess/WebContextClient.cpp:
* Source/WebKit/UIProcess/WebFrameProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebProcessPool.cpp:
* Source/WebKit/UIProcess/WebProcessPool.h:
* Source/WebKit/UIProcess/mac/WKFullScreenWindowController.h:
* Source/WebKit/UIProcess/mac/WKTextFinderClient.mm:
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeContext.mm:
* Tools/WebKitTestRunner/TestController.cpp:
(WTR::TestController::createWebViewWithOptions):
(WTR::decidePolicyForSpeechRecognitionPermissionRequest): Deleted.
(WTR::TestController::completeSpeechRecognitionPermissionCheck): Deleted.
* Tools/WebKitTestRunner/TestController.h:




More information about the webkit-changes mailing list