[webkit-changes] [WebKit/WebKit] 9c0ec4: [AppleWin] Remove Windows code from PixelDumpSuppo...
EWS
noreply at github.com
Tue Feb 14 10:41:34 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 9c0ec4ce794727ac17dac792da8086fa1a438643
https://github.com/WebKit/WebKit/commit/9c0ec4ce794727ac17dac792da8086fa1a438643
Author: Brent Fulgham <bfulgham at webkit.org>
Date: 2023-02-14 (Tue, 14 Feb 2023)
Changed paths:
M Tools/DumpRenderTree/cg/PixelDumpSupportCG.cpp
M Tools/DumpRenderTree/cg/PixelDumpSupportCG.h
M Tools/DumpRenderTree/ios/PixelDumpSupportIOS.mm
M Tools/DumpRenderTree/mac/PixelDumpSupportMac.mm
Log Message:
-----------
[AppleWin] Remove Windows code from PixelDumpSupportCG
https://bugs.webkit.org/show_bug.cgi?id=252197
Reviewed by Don Olmstead and Darin Adler.
The testing code in PixelDumpSupportCG.h/PixelDumpSupportCG.cpp used to build on
Windows. We don't need this support anymore, and should remove it.
This change also switches from a raw buffer to a unique_ptr to clean up the
code a bit.
* Tools/DumpRenderTree/cg/PixelDumpSupportCG.cpp:
(computeSHA1HashStringForBitmapContext):
(createBitmapContext):
* Tools/DumpRenderTree/cg/PixelDumpSupportCG.h:
(BitmapContext::createByAdoptingBitmapAndContext):
(BitmapContext::BitmapContext):
(BitmapContext::~BitmapContext): Deleted.
* Tools/DumpRenderTree/ios/PixelDumpSupportIOS.mm:
(createBitmapContextFromWebView): Remove unneeded buffer argument.
* Tools/DumpRenderTree/mac/PixelDumpSupportMac.mm:
(createBitmapContextFromWebView): Ditto.
(createPagedBitmapContext): Ditto.
Canonical link: https://commits.webkit.org/260265@main
More information about the webkit-changes
mailing list