[webkit-changes] [WebKit/WebKit] 999e65: [Cocoa] Replace bool parameter to preparePlatformF...

Myles C. Maxfield noreply at github.com
Tue Feb 14 02:53:06 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 999e6580a40d042a8ee57e24284005f299448cdf
      https://github.com/WebKit/WebKit/commit/999e6580a40d042a8ee57e24284005f299448cdf
  Author: Myles C. Maxfield <mmaxfield at apple.com>
  Date:   2023-02-14 (Tue, 14 Feb 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp
    M Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.h
    M Source/WebCore/platform/graphics/cocoa/UnrealizedCoreTextFont.cpp
    M Source/WebCore/platform/graphics/cocoa/UnrealizedCoreTextFont.h

  Log Message:
  -----------
  [Cocoa] Replace bool parameter to preparePlatformFont() with a 2-state enum
https://bugs.webkit.org/show_bug.cgi?id=252232
rdar://105439787

Reviewed by Tim Nguyen.

WebKit style prefers 2-state enums for parameters instead of bools.

* Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::preparePlatformFont):
(WebCore::fontWithFamily):
* Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.h:

Canonical link: https://commits.webkit.org/260250@main




More information about the webkit-changes mailing list