[webkit-changes] [WebKit/WebKit] 6f7d21: Make CachedSubimage part of PDFDocumentImage

Said Abou-Hallawa noreply at github.com
Mon Feb 13 17:56:15 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6f7d211e4d86c1f971e681af47732554e88fd49d
      https://github.com/WebKit/WebKit/commit/6f7d211e4d86c1f971e681af47732554e88fd49d
  Author: Said Abou-Hallawa <said at apple.com>
  Date:   2023-02-13 (Mon, 13 Feb 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/CachedSubimage.cpp
    M Source/WebCore/platform/graphics/CachedSubimage.h
    M Source/WebCore/platform/graphics/GraphicsContext.cpp
    M Source/WebCore/platform/graphics/Image.cpp
    M Source/WebCore/platform/graphics/Image.h
    M Source/WebCore/platform/graphics/cg/PDFDocumentImage.cpp
    M Source/WebCore/platform/graphics/cg/PDFDocumentImage.h
    M Source/WebCore/testing/Internals.cpp

  Log Message:
  -----------
  Make CachedSubimage part of PDFDocumentImage
https://bugs.webkit.org/show_bug.cgi?id=252129
rdar://105351788

Reviewed by Simon Fraser.

It makes sense for now to have CachedSubimage be part of PDFDocumentImage only.
It can't be part of BitmapImage since it may display multiple NativeImages. So
in future patches, CachedSubimage will be made part of the NativeImage as well.

* Source/WebCore/platform/graphics/CachedSubimage.cpp:
(WebCore::CachedSubimage::create):
(WebCore::CachedSubimage::createPixelated):
(WebCore::CachedSubimage::createCachedSubimage): Deleted.
(WebCore::CachedSubimage::createPixelatedCachedSubimage): Deleted.
* Source/WebCore/platform/graphics/CachedSubimage.h:
(WebCore::CachedSubimage::imageBuffer const):
(WebCore::CachedSubimage::scaleFactor const):
(WebCore::CachedSubimage::destinationRect const):
(WebCore::CachedSubimage::sourceRect const):
* Source/WebCore/platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawImage):
* Source/WebCore/platform/graphics/Image.cpp:
(WebCore::Image::drawCachedSubimage): Deleted.
(WebCore::Image::destroyDecodedData): Deleted.
* Source/WebCore/platform/graphics/Image.h:
(WebCore::Image::destroyDecodedData):
(WebCore::Image::draw):
(WebCore::Image::cachedSubimageCreateCountForTesting const): Deleted.
(WebCore::Image::cachedSubimageDrawCountForTesting const): Deleted.
(WebCore::Image::drawCachedSubimage): Deleted.
* Source/WebCore/platform/graphics/cg/PDFDocumentImage.cpp:
(WebCore::PDFDocumentImage::createCachedSubimage):
(WebCore::PDFDocumentImage::drawPDFDocument):
(WebCore::PDFDocumentImage::drawFromCachedSubimage):
(WebCore::PDFDocumentImage::draw):
(WebCore::PDFDocumentImage::destroyDecodedData):
* Source/WebCore/platform/graphics/cg/PDFDocumentImage.h:
* Source/WebCore/testing/Internals.cpp:
(WebCore::pdfDocumentImageFromImageElement):
(WebCore::Internals::imageCachedSubimageCreateCount):

Canonical link: https://commits.webkit.org/260236@main




More information about the webkit-changes mailing list