[webkit-changes] [WebKit/WebKit] dd5f2c: [web-animations] test failures with multiple font-...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dd5f2cbaaffbc88e2cf8b38106eafddce69c1e3a
      https://github.com/WebKit/WebKit/commit/dd5f2cbaaffbc88e2cf8b38106eafddce69c1e3a
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2023-02-13 (Mon, 13 Feb 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt
    M Source/WebCore/animation/CSSPropertyAnimation.cpp
    M Source/WebCore/css/ComputedStyleExtractor.cpp
    M Source/WebCore/platform/graphics/FontTaggedSettings.h

  Log Message:
  -----------
  [web-animations] test failures with multiple font-variation-settings duplicate tags
https://bugs.webkit.org/show_bug.cgi?id=252168

Reviewed by Myles C. Maxfield.

We failed to deduplicate tags when considering whether to interpolate font-variation-settings
values. We take some deduplication code written for the computed style representation of this
property and expose it via a deduplicate() method on FontTaggedSettings such that we may call
it while blending. This allows us to now compare font-variation-settings values with deduplicated
and sorted tags.

* LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:
* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::PropertyWrapperGetter::value const):
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
* Source/WebCore/platform/graphics/FontTaggedSettings.h:
(WebCore::FontTaggedSettings<T>::deduplicated const):

Canonical link: https://commits.webkit.org/260212@main