[webkit-changes] [WebKit/WebKit] 718d6e: [WGSL] Replace m_emptySourceSpan with SourceSpan::...

Tadeu Zagallo noreply at github.com
Mon Feb 13 02:19:08 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 718d6e1306d2ac0d5ee5b4e9095c7f2cfb420b03
      https://github.com/WebKit/WebKit/commit/718d6e1306d2ac0d5ee5b4e9095c7f2cfb420b03
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2023-02-13 (Mon, 13 Feb 2023)

  Changed paths:
    M Source/WebGPU/WGSL/EntryPointRewriter.cpp
    M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp

  Log Message:
  -----------
  [WGSL] Replace m_emptySourceSpan with SourceSpan::empty
https://bugs.webkit.org/show_bug.cgi?id=251840
rdar://105118434

Reviewed by Myles C. Maxfield.

Given that `SourceSpan::empty` was recently added, use it in favor of
EntryPointRewriter::m_emptySourceSpan and an explicit allocation of an
empty SourceSpan in RewriteGlobalVariables.

* Source/WebGPU/WGSL/EntryPointRewriter.cpp:
(WGSL::EntryPointRewriter::EntryPointRewriter):
(WGSL::EntryPointRewriter::rewrite):
(WGSL::EntryPointRewriter::constructInputStruct):
(WGSL::EntryPointRewriter::materialize):
(WGSL::EntryPointRewriter::visit):
(WGSL::EntryPointRewriter::appendBuiltins):
* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::insertStructs):

Canonical link: https://commits.webkit.org/260188@main




More information about the webkit-changes mailing list