[webkit-changes] [WebKit/WebKit] 2503db: Unreviewed build fix for Clang-libstdc++ combo

Žan Doberšek noreply at github.com
Mon Feb 13 01:37:28 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2503db97525bf509527a0a7df0b8dbdd0e13cff3
      https://github.com/WebKit/WebKit/commit/2503db97525bf509527a0a7df0b8dbdd0e13cff3
  Author: Žan Doberšek <zdobersek at igalia.com>
  Date:   2023-02-13 (Mon, 13 Feb 2023)

  Changed paths:
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp

  Log Message:
  -----------
  Unreviewed build fix for Clang-libstdc++ combo
https://bugs.webkit.org/show_bug.cgi?id=252156

Unreviewed build fix after 260175 at main for Clang and libstdc++ builds.

Assignment of CSSRadialGradientValue::GradientBox variant with a
CSSGradientPosition value is causing compilation failures due to other variant
types that are somehow treated as constructible in this case, due to
CSSGradientPosition being a pair of Ref<CSSValue> values and other variants
having a pair of Ref<CSSPrimitiveValue> values as their first members.

This is avoidable by reconstructing the variant and using the std::in_place_type
helper to explicitly specify that the CSSGradientPosition value should be used
in the variant.

* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeRadialGradient):

Canonical link: https://commits.webkit.org/260186@main




More information about the webkit-changes mailing list