[webkit-changes] [WebKit/WebKit] c2d057: [WGSL] Move WGSL types into their own namespace

Tadeu Zagallo noreply at github.com
Mon Feb 13 00:32:23 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c2d05736104ffce70b1a7f01730f1a7db31be50a
      https://github.com/WebKit/WebKit/commit/c2d05736104ffce70b1a7f01730f1a7db31be50a
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2023-02-13 (Mon, 13 Feb 2023)

  Changed paths:
    M Source/WebGPU/WGSL/TypeCheck.cpp
    M Source/WebGPU/WGSL/TypeStore.cpp
    M Source/WebGPU/WGSL/TypeStore.h
    M Source/WebGPU/WGSL/Types.cpp
    M Source/WebGPU/WGSL/Types.h

  Log Message:
  -----------
  [WGSL] Move WGSL types into their own namespace
https://bugs.webkit.org/show_bug.cgi?id=252109
rdar://105329210

Reviewed by Myles C. Maxfield.

`WGSL::Vector` was clashing with `WTF::Vector`, so we move all the specific WGSL
types (i.e. `Primitive`, `Vector`, etc) into the `WGSL::Types` namespace while
keeping the main `Type` in the top-level `WGSL` namespace.

* Source/WebGPU/WGSL/TypeCheck.cpp:
* Source/WebGPU/WGSL/TypeStore.cpp:
* Source/WebGPU/WGSL/TypeStore.h:
* Source/WebGPU/WGSL/Types.cpp:
(WGSL::Type::dump const):
(WGSL::Type::toString const):
(WGSL::printInternal): Deleted.
(WGSL::toString): Deleted.
* Source/WebGPU/WGSL/Types.h:

Canonical link: https://commits.webkit.org/260182@main




More information about the webkit-changes mailing list