[webkit-changes] [WebKit/WebKit] 05b9bd: [Win] REGRESSION(260060 at main) run-webkit-tests doe...

Fujii Hironori noreply at github.com
Sun Feb 12 22:10:08 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 05b9bdf1e05b4e6145b1c68dedf5c3c44bc4a395
      https://github.com/WebKit/WebKit/commit/05b9bdf1e05b4e6145b1c68dedf5c3c44bc4a395
  Author: Fujii Hironori <Hironori.Fujii at sony.com>
  Date:   2023-02-12 (Sun, 12 Feb 2023)

  Changed paths:
    M Tools/Scripts/webkitpy/port/win.py
    M Tools/Scripts/webkitpy/port/win_unittest.py

  Log Message:
  -----------
  [Win] REGRESSION(260060 at main) run-webkit-tests doesn't start a browser for results.html
https://bugs.webkit.org/show_bug.cgi?id=252144

Reviewed by Ross Kirsling.

On Windows, run-webkit-tests used run-safari script to start
MiniBrowser to show results.html. run-safari didn't work after
260060 at main changed the default Windows port name to WinCairo.

Use show_results_html_file of base.py to use the system's default
browser.

* Tools/Scripts/webkitpy/port/win.py:
(WinPort._port_flag_for_scripts):
(WinPort.show_results_html_file): Deleted.
* Tools/Scripts/webkitpy/port/win_unittest.py:
(WinPortTest):
(WinPortTest.test_show_results_html_file): Deleted.

Canonical link: https://commits.webkit.org/260178@main




More information about the webkit-changes mailing list