[webkit-changes] [WebKit/WebKit] bfe583: Cherry-pick 256825 at main (3894c75f5f9f). https://bu...

Adrian Perez noreply at github.com
Sat Feb 11 14:55:10 PST 2023


  Branch: refs/heads/webkitglib/2.38
  Home:   https://github.com/WebKit/WebKit
  Commit: bfe58342f50ce4a08df929cc25ecfe93d2756e1e
      https://github.com/WebKit/WebKit/commit/bfe58342f50ce4a08df929cc25ecfe93d2756e1e
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-02-11 (Sat, 11 Feb 2023)

  Changed paths:
    A LayoutTests/css3/filters/effect-drop-shadow-clip-abspos-expected.html
    A LayoutTests/css3/filters/effect-drop-shadow-clip-abspos.html
    M Source/WebCore/rendering/RenderLayer.cpp

  Log Message:
  -----------
  Cherry-pick 256825 at main (3894c75f5f9f). https://bugs.webkit.org/show_bug.cgi?id=247961

    Fix for pixel-moving CSS filters with clipping

    Fix for pixel-moving CSS filters with clipping
    https://bugs.webkit.org/show_bug.cgi?id=247961

    Reviewed by Simon Fraser.

    Merge - https://src.chromium.org/viewvc/blink?view=revision&revision=180361

    When using a "pixel-moving" filter (ie., drop-shadow or blur), we
    disable the normal clip operation, since we want to want to render
    the full results of the element pre-clip for filtering. Clipping is
    then applied just before drawing the filtered result.

    However, we shouldn't disable *all* clipping recursively, since we
    want children which clip themselves to still continue to be clipped.
    The fix is to pass the original (unmodified) paintingInfo to
    paintChildren().

    NOTE - The test case has been slightly modified to apply blur to reflect the issue.

    * Source/WebCore/rendering/RenderLayer.cpp:
    (RenderLayer::paintLayerContents): Update to take "original" paintingInfo
    * LayoutTests/css3/filters/effect-drop-shadow-clip-abpos.html: Added Test Case
    * LayoutTests/css3/filters/effect-drop-shadow-clip-abpos-expected.html: Added Test Case Expectations

    Canonical link: https://commits.webkit.org/256825@main


  Commit: 891ee0a2dd217ffc64f2d721f3880304567d6ace
      https://github.com/WebKit/WebKit/commit/891ee0a2dd217ffc64f2d721f3880304567d6ace
  Author: Alex Christensen <achristensen at webkit.org>
  Date:   2023-02-11 (Sat, 11 Feb 2023)

  Changed paths:
    M Source/WebKit/Platform/IPC/ArgumentCoders.h

  Log Message:
  -----------
  Cherry-pick 259917 at main (23f2542385a7). https://bugs.webkit.org/show_bug.cgi?id=251804

    Limit untrusted allocations when decoding Vectors to 1MB
    https://bugs.webkit.org/show_bug.cgi?id=251804

    Reviewed by Kimmo Kinnunen.

    257725 at main introduced a performance improvement where we only allocate exactly as much
    memory as we need once when decoding a Vector.  This is wonderful, but it introduced
    allocation based on size from an untrusted source, making it so any message that sends
    a Vector can be used to send a very large size_t and crash the other process.  In this
    PR I get the best of both worlds: if the total allocation size is less that 1MB then we
    do the fast and efficient thing, but if it is more than 1MB we do the safe thing.

    * Source/WebKit/Platform/IPC/ArgumentCoders.h:

    Canonical link: https://commits.webkit.org/259917@main


  Commit: 7f650fb65dfa4ac129248602bec767f3b0474fe5
      https://github.com/WebKit/WebKit/commit/7f650fb65dfa4ac129248602bec767f3b0474fe5
  Author: Philippe Normand <philn at igalia.com>
  Date:   2023-02-11 (Sat, 11 Feb 2023)

  Changed paths:
    M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp

  Log Message:
  -----------
  Cherry-pick 259953 at main (9512db61a188). https://bugs.webkit.org/show_bug.cgi?id=251791

    REGRESSION(258658 at main): [GStreamer][WebRTC] Broke webrtc/multi-video.html
    https://bugs.webkit.org/show_bug.cgi?id=251791

    Reviewed by Xabier Rodriguez-Calvar.

    The msid fallback assignment mechanism was not working as expected. In cases where the pad msid
    property was not set, the resulting mediaStreamId was the pad name, no msid lookup was performed in
    the SDP.

    * Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:
    (WebCore::GStreamerMediaEndpoint::requestPad):
    (WebCore::GStreamerMediaEndpoint::addRemoteStream):

    Canonical link: https://commits.webkit.org/259953@main


  Commit: 4c25e39c993c1a46405301167dc2f3a6cabc2809
      https://github.com/WebKit/WebKit/commit/4c25e39c993c1a46405301167dc2f3a6cabc2809
  Author: Adrian Perez de Castro <aperez at igalia.com>
  Date:   2023-02-12 (Sun, 12 Feb 2023)

  Changed paths:
    M Source/WebCore/html/HTMLInputElement.cpp

  Log Message:
  -----------
  Unreviewed non-unified build fix

* Source/WebCore/html/HTMLInputElement.cpp: Add missing EventLoop.h
  header inclusion.


Compare: https://github.com/WebKit/WebKit/compare/5855b42d8d3d...4c25e39c993c


More information about the webkit-changes mailing list