[webkit-changes] [WebKit/WebKit] a24ac1: Remove code in common files only compiled for Appl...

Brent Fulgham noreply at github.com
Fri Feb 10 16:24:46 PST 2023 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a24ac189df77eb8e7d2d17f1b4bc8dc2386facc5
      https://github.com/WebKit/WebKit/commit/a24ac189df77eb8e7d2d17f1b4bc8dc2386facc5
  Author: Brent Fulgham <bfulgham at apple.com>
  Date:   2023-02-10 (Fri, 10 Feb 2023)

  Changed paths:
    M Source/WebCore/PlatformMac.cmake
    M Source/WebCore/SourcesCocoa.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/WebCorePrefix.h
    M Source/WebCore/loader/EmptyClients.cpp
    M Source/WebCore/loader/EmptyFrameLoaderClient.h
    M Source/WebCore/loader/FrameLoaderClient.h
    M Source/WebCore/loader/ResourceLoader.h
    R Source/WebCore/loader/cf/ResourceLoaderCFNet.cpp
    M Source/WebCore/platform/MIMETypeRegistry.cpp
    M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
    M Source/WebCore/platform/graphics/ca/PlatformCALayer.h
    M Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp
    M Source/WebCore/platform/graphics/cg/ImageBufferCGBackend.cpp
    M Source/WebCore/platform/graphics/cg/ImageBufferUtilitiesCG.cpp
    M Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp
    R Source/WebCore/platform/graphics/cg/ImageSourceCG.h
    M Source/WebCore/platform/graphics/cg/PDFDocumentImage.cpp
    M Source/WebCore/platform/graphics/cg/PathCG.cpp
    M Source/WebCore/platform/graphics/cg/UTIRegistry.cpp
    M Source/WebCore/platform/graphics/cg/UTIRegistry.h
    M Source/WebCore/platform/graphics/cocoa/MediaPlaybackTargetContext.h
    M Source/WebCore/platform/graphics/coretext/FontCascadeCoreText.cpp
    M Source/WebCore/platform/graphics/coretext/FontCoreText.cpp
    M Source/WebCore/platform/graphics/coretext/GlyphPageCoreText.cpp
    M Source/WebCore/platform/mediastream/cocoa/AudioMediaStreamTrackRendererInternalUnit.cpp
    M Source/WebCore/platform/network/NetworkStorageSession.h
    M Source/WebCore/platform/network/ProtectionSpace.h
    M Source/WebCore/platform/network/ProtectionSpaceBase.cpp
    M Source/WebCore/platform/network/ResourceHandle.h
    M Source/WebCore/platform/network/ResourceHandleClient.h
    M Source/WebCore/platform/network/ResourceHandleInternal.h
    M Source/WebCore/platform/network/ResourceRequestBase.cpp
    R Source/WebCore/platform/network/cf/AuthenticationCF.cpp
    R Source/WebCore/platform/network/cf/AuthenticationCF.h
    M Source/WebCore/platform/network/cf/AuthenticationChallenge.h
    M Source/WebCore/platform/network/cf/CertificateInfoCFNet.cpp
    R Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp
    R Source/WebCore/platform/network/cf/CredentialStorageCFNet.cpp
    R Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp
    R Source/WebCore/platform/network/cf/LoaderRunLoopCF.h
    M Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp
    R Source/WebCore/platform/network/cf/ProtectionSpaceCFNet.cpp
    R Source/WebCore/platform/network/cf/ProtectionSpaceCFNet.h
    M Source/WebCore/platform/network/cf/ResourceError.h
    R Source/WebCore/platform/network/cf/ResourceErrorCF.cpp
    R Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp
    R Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegate.cpp
    R Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegate.h
    R Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp
    R Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.h
    M Source/WebCore/platform/network/cf/ResourceRequest.h
    M Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp
    M Source/WebCore/platform/network/cf/ResourceRequestCFNet.h
    M Source/WebCore/platform/network/cf/ResourceResponse.h
    R Source/WebCore/platform/network/cf/ResourceResponseCFNet.cpp
    M Source/WebCore/platform/network/cf/SocketStreamHandleImplCFNet.cpp
    R Source/WebCore/platform/network/cf/SynchronousLoaderClientCFNet.cpp
    M Source/WebCore/platform/network/cocoa/CredentialCocoa.h
    M Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.h
    M Source/WebCore/platform/network/mac/ResourceErrorMac.mm
    M Source/WebCore/platform/network/mac/ResourceHandleMac.mm
    M Source/WebCore/platform/win/TemporaryLinkStubs.cpp
    M Source/WebKitLegacy/WebCoreSupport/NetworkStorageSessionMap.cpp

  Log Message:
  -----------
  Remove code in common files only compiled for Apple's Windows port
https://bugs.webkit.org/show_bug.cgi?id=252018
<rdar://problem/105243320>

Reviewed by Alex Christensen.

This patch removes code that is no longer compiled on any platform, focused on the
CoreGraphics, CoreAnimation, and CFNetwork parts of the system.

It also moves some code from ImageSourceCG into UTIRegistry (since those methods were
only UTI-related).

* Source/WebCore/PlatformMac.cmake:
* Source/WebCore/SourcesCocoa.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/WebCorePrefix.h:
* Source/WebCore/loader/EmptyClients.cpp:
(WebCore::EmptyFrameLoaderClient::shouldCacheResponse): Deleted.
* Source/WebCore/loader/EmptyFrameLoaderClient.h:
* Source/WebCore/loader/FrameLoaderClient.h:
* Source/WebCore/loader/ResourceLoader.h:
* Source/WebCore/loader/cf/ResourceLoaderCFNet.cpp: Removed.
* Source/WebCore/platform/MIMETypeRegistry.cpp:
* Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::supportsAcceleratedFilterAnimations):
(WebCore::GraphicsLayer::supportsLayerType):
* Source/WebCore/platform/graphics/ca/PlatformCALayer.h:
* Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::setCGStyle):
(WebCore::GraphicsContextCG::didUpdateState):
* Source/WebCore/platform/graphics/cg/ImageBufferCGBackend.cpp:
(WebCore::ImageBufferCGBackend::contextColorSpace):
* Source/WebCore/platform/graphics/cg/ImageBufferUtilitiesCG.cpp:
* Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp:
(WebCore::ImageDecoderCG::setData):
(WebCore::sharedBufferGetBytesAtPosition): Deleted.
(WebCore::sharedBufferRelease): Deleted.
* Source/WebCore/platform/graphics/cg/ImageSourceCG.h: Removed.
* Source/WebCore/platform/graphics/cg/PDFDocumentImage.cpp:
(WebCore::PDFDocumentImage::drawPDFPage):
* Source/WebCore/platform/graphics/cg/PathCG.cpp:
(WebCore::Path::platformAddPathForRoundedRect):
* Source/WebCore/platform/graphics/cg/UTIRegistry.cpp:
(WebCore::MIMETypeForImageType):
(WebCore::preferredExtensionForImageType):
* Source/WebCore/platform/graphics/cg/UTIRegistry.h:
* Source/WebCore/platform/graphics/cocoa/MediaPlaybackTargetContext.h:
* Source/WebCore/platform/graphics/coretext/FontCascadeCoreText.cpp:
* Source/WebCore/platform/graphics/coretext/FontCoreText.cpp:
* Source/WebCore/platform/graphics/coretext/GlyphPageCoreText.cpp:
* Source/WebCore/platform/mediastream/cocoa/AudioMediaStreamTrackRendererInternalUnit.cpp:
* Source/WebCore/platform/network/NetworkStorageSession.h:
* Source/WebCore/platform/network/ProtectionSpace.h:
* Source/WebCore/platform/network/ProtectionSpaceBase.cpp:
* Source/WebCore/platform/network/ResourceHandle.h:
* Source/WebCore/platform/network/ResourceHandleClient.h:
* Source/WebCore/platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
* Source/WebCore/platform/network/ResourceRequestBase.cpp:
* Source/WebCore/platform/network/cf/AuthenticationCF.cpp: Removed.
* Source/WebCore/platform/network/cf/AuthenticationCF.h: Removed.
* Source/WebCore/platform/network/cf/AuthenticationChallenge.h:
(WebCore::AuthenticationChallenge::nsURLAuthenticationChallenge const):
(WebCore::AuthenticationChallenge::cfURLAuthChallengeRef const): Deleted.
* Source/WebCore/platform/network/cf/CertificateInfoCFNet.cpp:
(WebCore::CertificateInfo::certificateChainFromSecTrust):
(WebCore::CertificateInfo::containsNonRootSHA1SignedCertificate const):
(WebCore::CertificateInfo::summary const):
* Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp: Removed.
* Source/WebCore/platform/network/cf/CredentialStorageCFNet.cpp: Removed.
* Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp: Removed.
* Source/WebCore/platform/network/cf/LoaderRunLoopCF.h: Removed.
* Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp:
(WebCore::NetworkStorageSession::cookieStorage const):
* Source/WebCore/platform/network/cf/ProtectionSpaceCFNet.cpp: Removed.
* Source/WebCore/platform/network/cf/ProtectionSpaceCFNet.h: Removed.
* Source/WebCore/platform/network/cf/ResourceError.h:
(WebCore::ResourceError::ResourceError):
* Source/WebCore/platform/network/cf/ResourceErrorCF.cpp: Removed.
* Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp: Removed.
* Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegate.cpp: Removed.
* Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegate.h: Removed.
* Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp: Removed.
* Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.h: Removed.
* Source/WebCore/platform/network/cf/ResourceRequest.h:
(WebCore::ResourceRequest::ResourceRequest):
(WebCore::ResourceRequest::resourcePrioritiesEnabled):
* Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::isUserInitiatedKey):
(WebCore::setContentDispositionEncodingFallbackArray): Deleted.
(WebCore::copyContentDispositionEncodingFallbackArray): Deleted.
(WebCore::ResourceRequest::cfURLRequest const): Deleted.
(WebCore::setHeaderFields): Deleted.
(WebCore::toPlatformRequestCachePolicy): Deleted.
(WebCore::fromPlatformRequestCachePolicy): Deleted.
(WebCore::siteForCookies): Deleted.
(WebCore::ResourceRequest::doUpdatePlatformRequest): Deleted.
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody): Deleted.
(WebCore::ResourceRequest::doUpdateResourceRequest): Deleted.
(WebCore::ResourceRequest::doUpdateResourceHTTPBody): Deleted.
(WebCore::ResourceRequest::setStorageSession): Deleted.
* Source/WebCore/platform/network/cf/ResourceRequestCFNet.h:
* Source/WebCore/platform/network/cf/ResourceResponse.h:
(WebCore::ResourceResponse::ResourceResponse):
* Source/WebCore/platform/network/cf/ResourceResponseCFNet.cpp: Removed.
* Source/WebCore/platform/network/cf/SocketStreamHandleImplCFNet.cpp:
(WebCore::SocketStreamHandleImpl::SocketStreamHandleImpl):
(WebCore::SocketStreamHandleImpl::createStreams):
* Source/WebCore/platform/network/cf/SynchronousLoaderClientCFNet.cpp: Removed.
* Source/WebCore/platform/network/cocoa/CredentialCocoa.h:
* Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.h:
* Source/WebCore/platform/network/mac/ResourceErrorMac.mm:
(WebCore::ResourceError::ResourceError):
* Source/WebCore/platform/network/mac/ResourceHandleMac.mm:
* Source/WebCore/platform/win/TemporaryLinkStubs.cpp:
(WebCore::stopObservingCookieChanges):
* Source/WebKitLegacy/WebCoreSupport/NetworkStorageSessionMap.cpp:
(NetworkStorageSessionMap::switchToNewTestingSession):
(NetworkStorageSessionMap::ensureSession):

Canonical link: https://commits.webkit.org/260136@main

More information about the webkit-changes mailing list