[webkit-changes] [WebKit/WebKit] 6ba621: Reduce compile times by forward-declaring VideoFrame

Jer Noble noreply at github.com
Fri Feb 10 15:44:24 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6ba621fca3e768dedfaf203cbf576888a072368e
      https://github.com/WebKit/WebKit/commit/6ba621fca3e768dedfaf203cbf576888a072368e
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2023-02-10 (Fri, 10 Feb 2023)

  Changed paths:
    M Source/WebCore/Modules/speech/SpeechRecognitionCaptureSource.h
    M Source/WebCore/Modules/speech/SpeechRecognitionCaptureSourceImpl.h
    M Source/WebCore/Modules/webcodecs/WebCodecsVideoFrameAlgorithms.h
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/html/HTMLVideoElement.cpp
    M Source/WebCore/html/canvas/WebGL2RenderingContext.cpp
    M Source/WebCore/html/canvas/WebGLRenderingContext.cpp
    M Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
    M Source/WebCore/html/canvas/WebGLRenderingContextBase.h
    M Source/WebCore/platform/VideoDecoder.cpp
    M Source/WebCore/platform/VideoDecoder.h
    M Source/WebCore/platform/graphics/GraphicsContext.cpp
    M Source/WebCore/platform/graphics/MediaPlayer.cpp
    M Source/WebCore/platform/graphics/MediaPlayer.h
    A Source/WebCore/platform/graphics/MediaPlayerPrivate.cpp
    M Source/WebCore/platform/graphics/MediaPlayerPrivate.h
    M Source/WebCore/platform/graphics/avfoundation/SampleBufferDisplayLayer.h
    M Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.h
    M Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm
    M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h
    M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h
    M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h
    M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm
    M Source/WebCore/platform/graphics/cocoa/MediaPlayerPrivateWebM.h
    M Source/WebCore/platform/graphics/cv/ImageTransferSessionVT.h
    M Source/WebCore/platform/graphics/cv/ImageTransferSessionVT.mm
    M Source/WebCore/platform/mediarecorder/MediaRecorderPrivateAVFImpl.h
    M Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp
    M Source/WebCore/platform/mediastream/RealtimeMediaSource.h
    M Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.cpp
    M Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.h
    M Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.h
    M Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.h
    M Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp
    M Source/WebCore/platform/mock/MockRealtimeVideoSource.h
    M Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.h
    M Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.mm
    M Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.h
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
    M Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h
    M Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.h
    M Source/WebKit/WebProcess/GPU/webrtc/SampleBufferDisplayLayer.h
    M Source/WebKit/WebProcess/GPU/webrtc/SharedVideoFrame.h
    M Source/WebKit/WebProcess/cocoa/RemoteCaptureSampleManager.h
    M Source/WebKit/WebProcess/cocoa/RemoteRealtimeAudioSource.h
    M Source/WebKit/WebProcess/cocoa/RemoteRealtimeVideoSource.h

  Log Message:
  -----------
  Reduce compile times by forward-declaring VideoFrame
https://bugs.webkit.org/show_bug.cgi?id=251923
<rdar://problem/105278817>

Reviewed by Cameron McCormack.

Move the declaration of VideoFrame::Rotation out of VideoFrame so that it can be forward-declared.

Move all initializers that reference VideoFrame::Rotation values out-of-line.

Not including VideoFrame.h everywhere exposes other header problems, such as WTF::MediaTime
not being included. Make sure WTF::MediaTime is forward-declared in these instances, or
included where necessary.

Canonical link: https://commits.webkit.org/260132@main




More information about the webkit-changes mailing list