[webkit-changes] [WebKit/WebKit] cf1ebf: Interaction regions do not work for clients who us...

Tim Horton noreply at github.com
Fri Feb 10 14:19:21 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cf1ebf6421416419bd23b196a31f0f43a985a743
      https://github.com/WebKit/WebKit/commit/cf1ebf6421416419bd23b196a31f0f43a985a743
  Author: Tim Horton <thorton at apple.com>
  Date:   2023-02-10 (Fri, 10 Feb 2023)

  Changed paths:
    M Source/WebCore/page/InteractionRegion.cpp

  Log Message:
  -----------
  Interaction regions do not work for clients who use WebKit autosizing API
https://bugs.webkit.org/show_bug.cgi?id=251658
rdar://104871583

Reviewed by Wenson Hsieh.

* Source/WebCore/page/InteractionRegion.cpp:
(WebCore::interactionRegionForRenderedRegion):
The code to avoid interaction regions that take more than half the viewport
had a minor flaw that only comes up for clients who use the autosizing API:
in fixed-width flexible-height mode, the main frame's fixed layout size
always has a height of 1px, causing the area check to fail on all but the
smallest of interactible elements.

Instead of looking at the layout size, use the actual size of the FrameView.

Canonical link: https://commits.webkit.org/260127@main




More information about the webkit-changes mailing list