[webkit-changes] [WebKit/WebKit] 397fe1: bmalloc DebugHeap should not crash in low-memory c...

jjgriego noreply at github.com
Fri Feb 10 10:21:57 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 397fe12d87a4c4485ff80bf963e43629acb647fa
      https://github.com/WebKit/WebKit/commit/397fe12d87a4c4485ff80bf963e43629acb647fa
  Author: Joseph Griego <jgriego at igalia.com>
  Date:   2023-02-10 (Fri, 10 Feb 2023)

  Changed paths:
    M Source/bmalloc/bmalloc/DebugHeap.cpp

  Log Message:
  -----------
  bmalloc DebugHeap should not crash in low-memory conditions on Linux
https://bugs.webkit.org/show_bug.cgi?id=252053

Reviewed by Yusuke Suzuki.

`posix_memalign` may not initialize the result pointer if it fails on Linux [1].

If we don't initialize the result ourselves, this manifests as later
segfaults/bus errors/bizarre behavior as we get a completely bogus result that
can point basically anywhere.

[1] https://man7.org/linux/man-pages/man3/posix_memalign.3.html

* Source/bmalloc/bmalloc/DebugHeap.cpp:
(bmalloc::DebugHeap::memalign):

Canonical link: https://commits.webkit.org/260115@main




More information about the webkit-changes mailing list