[webkit-changes] [WebKit/WebKit] 87f47a: [web-animations] web-animations/interfaces/Animata...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 87f47a6461e3f8051550797467b2071f43eb6304
      https://github.com/WebKit/WebKit/commit/87f47a6461e3f8051550797467b2071f43eb6304
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2023-02-09 (Thu, 09 Feb 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate-no-browsing-context-expected.txt
    M Source/WebCore/animation/AnimationEffect.h
    M Source/WebCore/animation/KeyframeEffect.cpp
    M Source/WebCore/animation/KeyframeEffect.h
    M Source/WebCore/animation/WebAnimation.cpp

  Log Message:
  -----------
  [web-animations] web-animations/interfaces/Animatable/animate-no-browsing-context.html is a unique failure
https://bugs.webkit.org/show_bug.cgi?id=186494
rdar://problem/41000163

Reviewed by Dean Jackson.

The Web Animations spec defines several factors for an animation to be considered "ready" [0], one being
that the "user agent has completed any setup required to begin the playback of the animation's associated
effect including rendering the first frame of any keyframe effect".

While it does not specifically calls out the lack of a browsing context for the associated effect's target's
document, there certainly won't be any frames rendered in that specific case. So we do not run pending tasks,
the condition for the "ready" promise to resolve, if the associated effect is associated with a document
lacking a browsing context.

I filed a spec issue [1] to clarify this in the spec, but I believe the spirit of the spec already goes in
the direction of this test.

[0] https://drafts.csswg.org/web-animations-1/#ready
[1] https://github.com/w3c/csswg-drafts/issues/8439

* LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate-no-browsing-context-expected.txt:
* Source/WebCore/animation/AnimationEffect.h:
(WebCore::AnimationEffect::preventsAnimationReadiness const):
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::preventsAnimationReadiness const):
* Source/WebCore/animation/KeyframeEffect.h:
* Source/WebCore/animation/WebAnimation.cpp:
(WebCore::WebAnimation::tick):

Canonical link: https://commits.webkit.org/260101@main