[webkit-changes] [WebKit/WebKit] 49c625: Fix IPC tests in debug asan builds
EWS
noreply at github.com
Thu Feb 9 18:16:23 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 49c62543693ff07b48240a36c4a8cadc23cd41db
https://github.com/WebKit/WebKit/commit/49c62543693ff07b48240a36c4a8cadc23cd41db
Author: Alex Christensen <achristensen at webkit.org>
Date: 2023-02-09 (Thu, 09 Feb 2023)
Changed paths:
M Tools/TestWebKitAPI/Tests/IPC/ConnectionTests.cpp
M Tools/TestWebKitAPI/Tests/IPC/StreamConnectionTests.cpp
Log Message:
-----------
Fix IPC tests in debug asan builds
https://bugs.webkit.org/show_bug.cgi?id=251813
Reviewed by Kimmo Kinnunen.
There were two issues:
1. workQueueWait was referenced after its stack scope during test tear-down.
Make it static to extend its scope past the '}'
2. ReceiveAlreadyInvalidatedClientNoAssert hit a stack overflow because asan
uses a little more stack space. Just reduce 1000 iterations to 800 to
make that test also run successfully.
* Tools/TestWebKitAPI/Tests/IPC/ConnectionTests.cpp:
(TestWebKitAPI::TEST_P):
* Tools/TestWebKitAPI/Tests/IPC/StreamConnectionTests.cpp:
(TestWebKitAPI::TEST_P):
Canonical link: https://commits.webkit.org/260099@main
More information about the webkit-changes
mailing list