[webkit-changes] [WebKit/WebKit] eca2f1: Adjust more DOM-API-exposed screen metrics in head...

Wenson Hsieh noreply at github.com
Thu Feb 9 15:52:54 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: eca2f1b98440149e370561150edd521ee5c71cf7
      https://github.com/WebKit/WebKit/commit/eca2f1b98440149e370561150edd521ee5c71cf7
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2023-02-09 (Thu, 09 Feb 2023)

  Changed paths:
    M Source/WebCore/page/DOMWindow.cpp
    M Source/WebCore/page/Frame.cpp
    M Source/WebCore/page/Page.cpp
    M Source/WebCore/page/Page.h
    M Source/WebCore/page/Screen.cpp

  Log Message:
  -----------
  Adjust more DOM-API-exposed screen metrics in headless browsing mode
https://bugs.webkit.org/show_bug.cgi?id=251962
rdar://105198575

Reviewed by Tim Horton.

Align a number of screen-related web APIs in headless browsing mode, such that we fall back to a
screen rect that's positioned at the origin `(0, 0)`, with dimensions `(innerWidth, innerHeight)`.

* Source/WebCore/page/DOMWindow.cpp:
(WebCore::DOMWindow::outerHeight const):
(WebCore::DOMWindow::outerWidth const):
(WebCore::DOMWindow::screenX const):
(WebCore::DOMWindow::screenY const):
(WebCore::isLoadingInHeadlessMode): Deleted.
* Source/WebCore/page/Frame.cpp:
(WebCore::Frame::screenSize const):
* Source/WebCore/page/Page.cpp:
(WebCore::Page::isLoadingInHeadlessMode const):
* Source/WebCore/page/Page.h:
* Source/WebCore/page/Screen.cpp:
(WebCore::isLoadingInHeadlessMode):
(WebCore::Screen::height const):
(WebCore::Screen::width const):
(WebCore::Screen::colorDepth const):
(WebCore::Screen::pixelDepth const):
(WebCore::Screen::availLeft const):
(WebCore::Screen::availTop const):
(WebCore::Screen::availHeight const):
(WebCore::Screen::availWidth const):

Canonical link: https://commits.webkit.org/260091@main




More information about the webkit-changes mailing list