[webkit-changes] [WebKit/WebKit] 0676ba: ProxyObject's "get" IC should throw an error in ca...

EWS noreply at github.com
Thu Feb 9 12:12:39 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0676bad565abafd4b685f61d647ee5cfdf2975a4
      https://github.com/WebKit/WebKit/commit/0676bad565abafd4b685f61d647ee5cfdf2975a4
  Author: Alexey Shvayka <ashvayka at apple.com>
  Date:   2023-02-09 (Thu, 09 Feb 2023)

  Changed paths:
    A JSTests/stress/proxy-get-missing-handler-inline-cache.js
    M Source/JavaScriptCore/builtins/ProxyHelpers.js

  Log Message:
  -----------
  ProxyObject's "get" IC should throw an error in case of non-callable non-nullish trap
https://bugs.webkit.org/show_bug.cgi?id=251945

Reviewed by Yusuke Suzuki.

This change fixes IC helper for ProxyObject's "get" trap to implement GetMethod per spec [1],
throwing a TypeError for non-callable non-nullish traps instead of forwarding [[Get]] to receiver.

[1]: https://tc39.es/ecma262/#sec-proxy-object-internal-methods-and-internal-slots-get-p-receiver (steps 5-6)

* JSTests/stress/proxy-get-missing-handler-inline-cache.js: Added.
* Source/JavaScriptCore/builtins/ProxyHelpers.js:
(linkTimeConstant.performProxyObjectGet):

Canonical link: https://commits.webkit.org/260077@main




More information about the webkit-changes mailing list