[webkit-changes] [WebKit/WebKit] cdf4a0: [IFC][Partial layout] Move some types out of LineB...

Alan Baradlay noreply at github.com
Thu Feb 9 07:19:55 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cdf4a0a4de73521d967836ef8b0d7b64a18bac57
      https://github.com/WebKit/WebKit/commit/cdf4a0a4de73521d967836ef8b0d7b64a18bac57
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-02-09 (Thu, 09 Feb 2023)

  Changed paths:
    M Source/WebCore/Headers.cmake
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.h
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h
    A Source/WebCore/layout/formattingContexts/inline/InlineLineTypes.h
    M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h
    M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.h

  Log Message:
  -----------
  [IFC][Partial layout] Move some types out of LineBuilder class
https://bugs.webkit.org/show_bug.cgi?id=251967

Reviewed by Antti Koivisto.

These type are used outside of LineBuilder (and the callers of LineBuilder).
(Also InlineLineTypes.h is going to be expanded with more of these type of common line layout structures)

* Source/WebCore/Headers.cmake:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:
(WebCore::Layout::lineEndingEllipsisPolicy):
(WebCore::Layout::InlineFormattingContext::lineLayout):
(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthForConstraint const):
(WebCore::Layout::InlineFormattingContext::createDisplayContentForLine):
(WebCore::Layout::InlineFormattingContext::resetGeometryForClampedContent):
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.h:
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::close):
(WebCore::Layout::LineBuilder::nextWrapOpportunity const):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h:
(WebCore::Layout::PartialContent::PartialContent):
(WebCore::Layout::LineBuilder::InlineItemRange::isEmpty const): Deleted.
(WebCore::Layout::LineBuilder::InlineItemRange::size const): Deleted.
(WebCore::Layout::LineBuilder::PartialContent::PartialContent): Deleted.
* Source/WebCore/layout/formattingContexts/inline/InlineLineTypes.h: Copied from Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.h.
(WebCore::Layout::InlineItemRange::isEmpty const):
(WebCore::Layout::InlineItemRange::size const):
* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h:
* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.cpp:
(WebCore::Layout::InlineDisplayLineBuilder::trailingEllipsisVisualRectAfterTruncation):
* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.h:

Canonical link: https://commits.webkit.org/260062@main




More information about the webkit-changes mailing list