[webkit-changes] [WebKit/WebKit] 1adec3: REGRESSION (259976 at main): [iOS / macOS] TestWebKit...

Timothy Hatcher noreply at github.com
Wed Feb 8 21:33:55 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1adec3c9e021542227dd5aa0c187adc9c975fd09
      https://github.com/WebKit/WebKit/commit/1adec3c9e021542227dd5aa0c187adc9c975fd09
  Author: Timothy Hatcher <timothy at apple.com>
  Date:   2023-02-08 (Wed, 08 Feb 2023)

  Changed paths:
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm

  Log Message:
  -----------
  REGRESSION (259976 at main): [iOS / macOS] TestWebKitAPI.URLSchemeHandler.DisableCORS is consistently failing
https://webkit.org/b/251935
rdar://105181176

Reviewed by Sihui Liu.

Remove the dynamic version of _corsDisablingPatterns on WKWebView, since it was was never adopted in Safari
and is not working correctly since SecurityPolicy never removes UserContentURLPatterns from the allowlist.
We are tracking updating this mechanism for extensions in rdar://102912898.

* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _corsDisablingPatterns]): Deleted.
(-[WKWebView _setCORSDisablingPatterns:]): Deleted.
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
Remove test for setting _corsDisablingPatterns on WKWebView.

Canonical link: https://commits.webkit.org/260048@main




More information about the webkit-changes mailing list