[webkit-changes] [WebKit/WebKit] e7fc85: Cherry-pick 4041735e0952. rdar://problem/105167931

Wed Feb 8 12:41:17 PST 2023

  Branch: refs/heads/safari-7616.1.1-branch
  Home:   https://github.com/WebKit/WebKit
  Commit: e7fc85376faa0da9ebef9718929ee0d0a7848eb0
      https://github.com/WebKit/WebKit/commit/e7fc85376faa0da9ebef9718929ee0d0a7848eb0
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2023-02-08 (Wed, 08 Feb 2023)

  Changed paths:
    M Source/ThirdParty/ANGLE/ANGLE.plist
    M Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj
    M Source/ThirdParty/ANGLE/DEPS
    M Source/ThirdParty/ANGLE/GLESv2.cmake
    M Source/ThirdParty/ANGLE/Metal.cmake
    M Source/ThirdParty/ANGLE/PRESUBMIT.py
    M Source/ThirdParty/ANGLE/changes.diff
    M Source/ThirdParty/ANGLE/doc/ContributingCode.md
    M Source/ThirdParty/ANGLE/gni/angle.gni
    M Source/ThirdParty/ANGLE/include/platform/FeaturesMtl_autogen.h
    M Source/ThirdParty/ANGLE/include/platform/FeaturesVk_autogen.h
    M Source/ThirdParty/ANGLE/include/platform/mtl_features.json
    M Source/ThirdParty/ANGLE/include/platform/vk_features.json
    M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/ANGLE_features.json
    M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/ANGLE_load_functions_table.json
    M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/GL_CTS_(dEQP)_build_files.json
    M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/Test_spec_JSON.json
    M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/Vulkan_format.json
    M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/Vulkan_mandatory_format_support_table.json
    M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/restricted_traces.json
    M Source/ThirdParty/ANGLE/scripts/generate_android_bp.py
    M Source/ThirdParty/ANGLE/src/angle_commit.h
    M Source/ThirdParty/ANGLE/src/common/ANGLEShaderProgramVersion.h
    A Source/ThirdParty/ANGLE/src/common/FixedQueue.h
    A Source/ThirdParty/ANGLE/src/common/FixedQueue_unittest.cpp
    M Source/ThirdParty/ANGLE/src/common/RingBufferAllocator.cpp
    M Source/ThirdParty/ANGLE/src/common/RingBufferAllocator.h
    M Source/ThirdParty/ANGLE/src/compiler/translator/tree_ops/apple/AddAndTrueToLoopCondition.h
    M Source/ThirdParty/ANGLE/src/compiler/translator/tree_ops/apple/RewriteDoWhile.h
    M Source/ThirdParty/ANGLE/src/compiler/translator/tree_ops/apple/RewriteRowMajorMatrices.h
    M Source/ThirdParty/ANGLE/src/compiler/translator/tree_ops/apple/RewriteUnaryMinusOperatorFloat.h
    M Source/ThirdParty/ANGLE/src/compiler/translator/tree_ops/gl/ClampFragDepth.h
    M Source/ThirdParty/ANGLE/src/compiler/translator/tree_ops/gl/RegenerateStructNames.h
    M Source/ThirdParty/ANGLE/src/compiler/translator/tree_ops/gl/RewriteRepeatedAssignToSwizzled.h
    M Source/ThirdParty/ANGLE/src/compiler/translator/tree_ops/gl/UseInterfaceBlockFields.h
    M Source/ThirdParty/ANGLE/src/image_util/loadimage.cpp
    M Source/ThirdParty/ANGLE/src/image_util/loadimage.h
    M Source/ThirdParty/ANGLE/src/libANGLE/Context.cpp
    M Source/ThirdParty/ANGLE/src/libANGLE/Context.inl.h
    M Source/ThirdParty/ANGLE/src/libANGLE/FramebufferAttachment.h
    M Source/ThirdParty/ANGLE/src/libANGLE/Image.cpp
    M Source/ThirdParty/ANGLE/src/libANGLE/Image.h
    M Source/ThirdParty/ANGLE/src/libANGLE/Surface.cpp
    M Source/ThirdParty/ANGLE/src/libANGLE/Surface.h
    M Source/ThirdParty/ANGLE/src/libANGLE/Texture.h
    M Source/ThirdParty/ANGLE/src/libANGLE/capture/FrameCapture.cpp
    M Source/ThirdParty/ANGLE/src/libANGLE/capture/FrameCapture.h
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/d3d/d3d11/Buffer11.cpp
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/load_functions_data.json
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/load_functions_table_autogen.cpp
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/BufferMtl.mm
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ContextMtl.mm
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/DisplayMtl.h
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/DisplayMtl.mm
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ProgramMtl.h
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ProgramMtl.mm
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/QueryMtl.h
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/QueryMtl.mm
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/metal_backend.gni
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_buffer_manager.h
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_buffer_manager.mm
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_buffer_pool.h
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_buffer_pool.mm
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_command_buffer.h
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_command_buffer.mm
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_context_device.h
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_context_device.mm
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_format_utils.h
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_format_utils.mm
    A Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_library_cache.h
    A Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_library_cache.mm
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_occlusion_query_pool.mm
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_resources.h
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_resources.mm
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_utils.h
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_utils.mm
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/renderermtl_utils.cpp
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/serial_utils.h
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/AllocatorHelperPool.h
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/AllocatorHelperRing.cpp
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/AllocatorHelperRing.h
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/CommandProcessor.cpp
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/CommandProcessor.h
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/ContextVk.cpp
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/ContextVk.h
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/DisplayVk.cpp
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/FramebufferVk.cpp
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/FramebufferVk.h
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/OverlayVk.cpp
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/RenderbufferVk.cpp
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/RendererVk.cpp
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/RendererVk.h
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/SecondaryCommandBuffer.h
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/SemaphoreVk.cpp
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/SurfaceVk.cpp
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/SurfaceVk.h
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/TextureVk.cpp
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/vk_caps_utils.cpp
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/vk_format_map.json
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/vk_format_table_autogen.cpp
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/vk_helpers.cpp
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/vk_helpers.h
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/vk_utils.cpp
    M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/vk_utils.h
    M Source/ThirdParty/ANGLE/src/libGLESv2.gni
    M Source/ThirdParty/ANGLE/src/tests/angle_end2end_tests_expectations.txt
    M Source/ThirdParty/ANGLE/src/tests/angle_unittests.gni
    M Source/ThirdParty/ANGLE/src/tests/deqp_support/deqp_khr_gles31_test_expectations.txt
    M Source/ThirdParty/ANGLE/src/tests/egl_tests/EGLSurfaceTest.cpp
    M Source/ThirdParty/ANGLE/src/tests/egl_tests/EGLSyncTest.cpp
    M Source/ThirdParty/ANGLE/src/tests/gl_tests/FragDepthTest.cpp
    M Source/ThirdParty/ANGLE/src/tests/gl_tests/MultithreadingTest.cpp
    M Source/ThirdParty/ANGLE/src/tests/gl_tests/TextureTest.cpp
    M Source/ThirdParty/ANGLE/src/tests/gl_tests/UniformTest.cpp
    M Source/ThirdParty/ANGLE/src/tests/restricted_traces/restricted_trace_gold_tests.py
    M Source/ThirdParty/ANGLE/src/tests/restricted_traces/restricted_traces.json
    M Source/ThirdParty/ANGLE/util/android/AndroidWindow.cpp
    M Source/ThirdParty/ANGLE/util/angle_features_autogen.cpp
    M Source/ThirdParty/ANGLE/util/angle_features_autogen.h

  Log Message:
  -----------
  Cherry-pick 4041735e0952. rdar://problem/105167931

    Update ANGLE to 2023-02-08 (a4c7abcbc1eb5b811e7a35af19d826ef02487540)
    https://bugs.webkit.org/show_bug.cgi?id=251908
    rdar://problem/105167931

    Unreviewed, to be reviewed by Dean Jackson.

    Contains upstream commits:
    git log --oneline 786d237f39f1ea0d85781c039d4218fcd2679156..a4c7abcbc1eb5b811e7a35af19d826ef02487540 --pretty=%h %s
    a4c7abcbc Advertise GL_OES_geometry_shader and GL_EXT_tessellation_shader
    9a6c90c8f Reland "Metal: Avoid leaking buffers for GPU access for non-discrete"
    ac0a4a7d3 Add finer memory allocation type
    9b2f52d2f Use WARN to log the allocation info on allocation failure
    b38467147 Vulkan: Feature to make async queue slow for testing
    28da0a3e9 Vulkan: Avoid swapchain recreation on present mode change
    ad81cc955 Vulkan: Switch CommandQueue::mInflightCommands to FixedQueue
    11951f2f4 Vulkan: Add FixedQueue class for CommandProcessor::mTask
    046db15c0 Vulkan: Remove redundant ImageState::sourceType
    a77e8e3ab Limit logging when invalid calls are not captured.
    0ee671456 Vulkan: Fix bug with ContextVk::mWaitSemaphores processing.
    b930cdbf9 Vulkan: Make CommandProcessor only wait for required work
    a88d9f03a Vulkan: Refactoring in RenderPassCommandBufferHelper.
    001b004d4 Vulkan: Fixed assert in DedicatedCommandBlockPool onNewCommand()
    36a4b33c4 Remove valid_param_values.h exception from export_targets
    c799074c7 Metal: Implement EXT_disjoint_timer_query.
    95c60d900 Fix broken links
    2510afd2c Enable Skia Gold inexact matching
    1857345f9 Improve logging when crashing due to locked screen.
    3886af6e4 Vulkan: Generalize AHB optimization prohibitions
    ef056a068 Vulkan: Use SubmitPolicy::AllowDeferred whenever possible.
    a54f91d01 Roll SwiftShader from bcb8f46b86b7 to 938d3a1fac4d (2 revisions)
    cc4834d2b Roll vulkan-deps from 57f61361acfb to 223515618c53 (5 revisions)
    a12dd26c9 Roll Chromium from 20c3dc51aba5 to 22b1fa2b9cc1 (546 revisions)
    fa0681d17 Vulkan: Per Context Serial cleanup.
    db86154e0 Adjust TextureState::isStencilMode
    3e5b36e4e Vulkan: ContextVk::finishImpl only wait for context's serial
    cae00d9bb Vulkan: Cleanup shared ring buffer cmd alloc feature.
    b96f3abd8 Vulkan: Make Context::mLastSubmittedSerial to QueueSerial
    3159a4dac Add temp gn_response_file to $(genDir) directory in Android build
    11366cbb4 Vulkan: Bug fix in flushDescriptorSetUpdates(...)
    ba7bae168 Roll vulkan-deps from 525984c7fd54 to 57f61361acfb (2 revisions)
    db8396fad Roll Chromium from c2710ae68385 to 20c3dc51aba5 (334 revisions)
    c58d70796 Manual roll vulkan-deps from 7ab598f59574 to 525984c7fd54 (14 revisions)
    6bdd90a7c Manual roll vulkan-deps from c7184adab227 to 7ab598f59574 (12 revisions)
    586f695ac Manual roll Chromium from 821732c56366 to c2710ae68385 (252 revisions)
    0b3cca880 Bypass commit message presubmit checks on manual rolls
    b925c43e9 Revert "Vulkan: Remove platform restriction of EGL_ANDROID_native_fence_sync"
    30a5b24c1 Roll VK-GL-CTS from 435efeefbc72 to a13cbc855993 (6 revisions)
    99063e20a Skip flaky crashing test on TSAN
    173003af1 Tests: Add Lilys Garden trace
    f852187df Vulkan: Remove platform restriction of EGL_ANDROID_native_fence_sync
    0210b46d3 Vulkan: Minor CommandQueue implementation refactoring.
    4391d8074 Metal: Fix gl_FragDepth shader specialization
    874d9f477 Roll Chromium from 7a3786ad50af to 821732c56366 (585 revisions)
    fee24cfbe Vulkan: Optimize BindingPointer move-constructor
    2f3ce7b69 Roll vulkan-deps from 30323acb3089 to c7184adab227 (11 revisions)
    1703c7309 Fix glMapBufferRange() failure with D3D11 backend
    9b00af526 Metal: Add an in-memory MTLLibrary cache.
    36199fa91 Roll VK-GL-CTS from bbf05746bf87 to 435efeefbc72 (1 revision)
    b23bf47c9 Reland "Metal: rewrite default uniforms and uniform blocks"
    587a19690 Enable X11 and OpenGL backends for CastOS.
    17931e23d Fix stencil and depth/stencil data uploads
    8fbd85b9b Roll SwiftShader from d25c7a174ad7 to bcb8f46b86b7 (1 revision)
    baeec4db1 Roll Chromium from f19a46134fe2 to 7a3786ad50af (602 revisions)
    2e9909f5e Metal: Enable Metal on iOS in gni build.
    91fdf3e66 Include atomic in RingBufferAllocator.h w/ ANGLE_ENABLE_ASSERTS
    0bbb50338 Check if multidraw calls are no-ops
    5a2d1ce98 Vulkan: Disable Imageless Framebuffer in some conditions.
    3e65d0b6f Test: Fixed EGLContext leak in the EGLSurfaceTest tests.
    360cd0d17 Include debug.h in various treeops headers
    9399c508e Tests: Add Piano Kids - Music & Songs trace
    6486b25ad Tests: Add 2 3 4 Player Mini Games trace
    fea282e5f Roll Chromium from b51474366e49 to f19a46134fe2 (381 revisions)
    754c923bf Tests: Add Callbreak trace
    9cc2a0b8c Remove EXT_polygon_offset_clamp suppressions
    e4dfdde9b Tests: Add Age of Origins Z trace
    ad4773040 Roll Chromium from 7a868f186276 to b51474366e49 (62 revisions)
    fb9483194 Revert "Metal: rewrite default uniforms and uniform blocks"
    6712c48e1 Skip flaky timeout test on Win SwANGLE
    c278f0389 Roll chromium_revision 12d1cf2574..7a868f1862 (1099244:1099248)
    ce8ce6f81 Remove ASSERT from AtomicSerial, use static_assert
    155a94d79 Vulkan: prefer D24_UNORM_X8_UINT as D32_UNORM fallback
    ef1ab2076 Roll vulkan-deps from be674ea25e15 to 30323acb3089 (14 revisions)
    2b7c06e31 Roll SwiftShader from aae98adc2222 to d25c7a174ad7 (3 revisions)

    Canonical link: https://commits.webkit.org/260005@main

Canonical link: https://commits.webkit.org/259456.418@safari-7616.1.1-branch


  Commit: e5d5fcabd1e7121fc0434902c9536bf6f61dbf60
      https://github.com/WebKit/WebKit/commit/e5d5fcabd1e7121fc0434902c9536bf6f61dbf60
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2023-02-08 (Wed, 08 Feb 2023)

  Changed paths:
    A LayoutTests/fullscreen/fullscreen-iframe-navigation-expected.html
    A LayoutTests/fullscreen/fullscreen-iframe-navigation.html
    A LayoutTests/fullscreen/resources/fullscreen-iframe-navigation-target.html
    M LayoutTests/platform/mac-wk1/TestExpectations
    M Source/WebCore/dom/FullscreenManager.cpp
    M Source/WebCore/dom/FullscreenManager.h

  Log Message:
  -----------
  Cherry-pick 9215d7d582cb. rdar://problem/104393093

    Navigation within iframe doesn't exit fullscreen for parent iframe element
    https://bugs.webkit.org/show_bug.cgi?id=251896
    rdar://104393093

    Reviewed by Chris Dumez.

    This was because the exiting document was already detached from the Frame object, causing it to fail to find the top document.
    To fix this, we store the top document when initializing FullscreenManager.

    * LayoutTests/fullscreen/fullscreen-iframe-navigation-expected.html: Added.
    * LayoutTests/fullscreen/fullscreen-iframe-navigation.html: Added.
    * LayoutTests/fullscreen/resources/fullscreen-iframe-navigation-target.html: Added.
    * LayoutTests/platform/mac-wk1/TestExpectations:
    * Source/WebCore/dom/FullscreenManager.cpp:
    (WebCore::FullscreenManager::cancelFullscreen):
    (WebCore::documentsToUnfullscreen):
    (WebCore::FullscreenManager::exitFullscreen):
    (WebCore::FullscreenManager::finishExitFullscreen):
    (WebCore::FullscreenManager::didExitFullscreen):
    * Source/WebCore/dom/FullscreenManager.h:

    Canonical link: https://commits.webkit.org/260024@main

Canonical link: https://commits.webkit.org/259456.419@safari-7616.1.1-branch


Compare: https://github.com/WebKit/WebKit/compare/df64e2c5c882...e5d5fcabd1e7