[webkit-changes] [WebKit/WebKit] c436cf: BuilderConverter::convertLineHeight() should not r...
Antoine Quint
noreply at github.com
Wed Feb 8 12:30:14 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c436cfbb0eb06b5f4c3dc74b893bdb787243e535
https://github.com/WebKit/WebKit/commit/c436cfbb0eb06b5f4c3dc74b893bdb787243e535
Author: Antoine Quint <graouts at webkit.org>
Date: 2023-02-08 (Wed, 08 Feb 2023)
Changed paths:
M Source/WebCore/css/CSSProperties.json
M Source/WebCore/style/StyleBuilderConverter.h
M Source/WebCore/style/StyleBuilderCustom.h
Log Message:
-----------
BuilderConverter::convertLineHeight() should not return an std::optional<Length>
https://bugs.webkit.org/show_bug.cgi?id=251914
Reviewed by Antti Koivisto.
This function can, and thus should, always return a Length.
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertLineHeight):
* Source/WebCore/style/StyleBuilderCustom.h:
(WebCore::Style::BuilderCustom::applyValueLineHeight):
Canonical link: https://commits.webkit.org/260027@main
More information about the webkit-changes
mailing list