[webkit-changes] [WebKit/WebKit] f5f87a: REGRESSION (258819 at main): Wolfram Alpha dropdown b...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f5f87a80a55638f20ce1b34fadcf5b1656a6aa35
      https://github.com/WebKit/WebKit/commit/f5f87a80a55638f20ce1b34fadcf5b1656a6aa35
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-02-08 (Wed, 08 Feb 2023)

  Changed paths:
    M LayoutTests/fast/block/height-percentage-descendants-with-absolute-pos-containingblock-expected.txt
    M LayoutTests/fast/repaint/box-shadow-top-left-repaint-expected.txt
    M LayoutTests/fast/repaint/focus-ring-repaint-expected.txt
    M LayoutTests/fast/repaint/leftover-after-shrinking-content-expected.txt
    M LayoutTests/fast/repaint/overlapping-lines-with-ink-overflow-expected.txt
    M LayoutTests/fast/repaint/simple-line-layout-shrinking-content-expected.txt
    A LayoutTests/fast/repaint/text-content-shrinks-repaint-expected.txt
    A LayoutTests/fast/repaint/text-content-shrinks-repaint.html
    M LayoutTests/fast/repaint/vertical-text-repaint-expected.txt
    M LayoutTests/platform/ios-wk2/fast/block/height-percentage-descendants-with-absolute-pos-containingblock-expected.txt
    M LayoutTests/platform/mac-wk1/fast/repaint/leftover-after-shrinking-content-expected.txt
    M Source/WebCore/rendering/RenderBlockFlow.cpp

  Log Message:
  -----------
  REGRESSION (258819 at main): Wolfram Alpha dropdown box has repaint artifacts
https://bugs.webkit.org/show_bug.cgi?id=251816
<rdar://104966985>

Reviewed by Antti Koivisto.

Due to eager display content invalidation, repaints issued after calling RenderBlockFlow::invalidateLineLayoutPath produce empty rects.

Normally this invalidation call is followed by a layout which will eventually issue another repaint. This second repaint, with no partial layout support in IFC (and most content are now covered by IFC)
we will most likely be a full, though redundant repaint.
(note that this newly introduced repaint may be overly inflated when tall container has constantly changing short inline content)

* LayoutTests/fast/repaint/text-content-shrinks-repaint-expected.txt: Added.
* LayoutTests/fast/repaint/text-content-shrinks-repaint.html: Added.
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::invalidateLineLayoutPath):

Canonical link: https://commits.webkit.org/260008@main