[webkit-changes] [WebKit/WebKit] 4a9e02: [GLIB] always update the active uri of the frame

Przemyslaw Gorszkowski noreply at github.com
Wed Feb 8 01:48:23 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4a9e02aa3418af0c2117db77f0e7edd70955fa23
      https://github.com/WebKit/WebKit/commit/4a9e02aa3418af0c2117db77f0e7edd70955fa23
  Author: Przemyslaw Gorszkowski <pgorszkowski at igalia.com>
  Date:   2023-02-08 (Wed, 08 Feb 2023)

  Changed paths:
    M Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitFrame.cpp
    M Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitFramePrivate.h
    M Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp
    M Tools/TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp

  Log Message:
  -----------
  [GLIB] always update the active uri of the frame
https://bugs.webkit.org/show_bug.cgi?id=251256

Reviewed by Carlos Garcia Campos.

It fixes the case when the uri has changed after first call of
webkit_frame_get_uri and then webkit_frame_get_uri is called again.
Without this fix the returned uri is the initial one not the actual one.

Test: I modified existing caillback for uri change and add there additional
asserts to test added functionality.

* Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitFrame.cpp:
(webkitFrameSetUri):
(webkit_frame_get_uri):
* Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitFramePrivate.h:
* Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp:
* Tools/TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
(uriChangedCallback):

Canonical link: https://commits.webkit.org/259999@main




More information about the webkit-changes mailing list