[webkit-changes] [WebKit/WebKit] 72357c: Use dynamicDowncast instead of downcast in Injecte...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 72357c53b5ff55ace758892da24cc4bd86f96c5c
      https://github.com/WebKit/WebKit/commit/72357c53b5ff55ace758892da24cc4bd86f96c5c
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-02-07 (Tue, 07 Feb 2023)

  Changed paths:
    M Source/WebKit/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp
    M Source/WebKit/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/DidResignInputElementStrongPasswordAppearance.mm

  Log Message:
  -----------
  Use dynamicDowncast instead of downcast in InjectedBundleNodeHandle::htmlIFrameElementContentFrame
https://bugs.webkit.org/show_bug.cgi?id=251882
rdar://105143592

Reviewed by Chris Dumez.

There was some unused code.  Removed.
We were downcasting to the wrong type.  Removed and replaced with dynamicDowncast.
I added the first use of htmlIFrameElementContentFrame in automated tests to prevent this in the future.

* Source/WebKit/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::htmlIFrameElementContentFrame):
(WebKit::InjectedBundleNodeHandle::htmlFrameElementContentFrame): Deleted.
* Source/WebKit/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/DidResignInputElementStrongPasswordAppearance.mm:
(-[DidResignInputElementStrongPasswordAppearance webProcessPlugIn:didCreateBrowserContextController:]):

Canonical link: https://commits.webkit.org/259985@main