[webkit-changes] [WebKit/WebKit] f0228a: DocumentLoader should use std::unique_ptr<ServiceW...

youennf noreply at github.com
Tue Feb 7 13:11:58 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f0228a3f07df4a195fa84f19ad20b86d9e265062
      https://github.com/WebKit/WebKit/commit/f0228a3f07df4a195fa84f19ad20b86d9e265062
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2023-02-07 (Tue, 07 Feb 2023)

  Changed paths:
    M Source/WebCore/loader/DocumentLoader.cpp
    M Source/WebCore/loader/DocumentLoader.h
    M Source/WebCore/workers/service/ServiceWorkerRegistrationData.h

  Log Message:
  -----------
  DocumentLoader should use std::unique_ptr<ServiceWorkerRegistrationData> rather than std::optional<>
https://bugs.webkit.org/show_bug.cgi?id=251772
rdar://problem/105074302

Reviewed by Chris Dumez.

Reduce memory consumption by storing service worker data in DocumentLoader as a separate pointer.
Covered by existing tests.

* Source/WebCore/loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::setControllingServiceWorkerRegistration):
(WebCore::DocumentLoader::responseReceived):
(WebCore::DocumentLoader::startLoadingMainResource):
* Source/WebCore/loader/DocumentLoader.h:
* Source/WebCore/workers/service/ServiceWorkerRegistrationData.h:

Canonical link: https://commits.webkit.org/259977@main




More information about the webkit-changes mailing list