[webkit-changes] [WebKit/WebKit] 2c7330: Table cells, rows, sections or column (groups) don...

Ahmad Saleem noreply at github.com
Tue Feb 7 03:05:48 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2c733023916d0038dab2838efb71304579f6848e
      https://github.com/WebKit/WebKit/commit/2c733023916d0038dab2838efb71304579f6848e
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-02-07 (Tue, 07 Feb 2023)

  Changed paths:
    M Source/WebCore/rendering/RenderBox.cpp
    M Source/WebCore/rendering/RenderTableRow.cpp

  Log Message:
  -----------
  Table cells, rows, sections or column (groups) don't support margins

Table cells, rows, sections or column (groups) don't support margins
https://bugs.webkit.org/show_bug.cgi?id=251100
rdar://problem/104876500

Reviewed by Alan Baradlay.

Merge - https://src.chromium.org/viewvc/blink?revision=197770&view=revision

This patch removes FIXME related 'if' clause and replaces with ASSERT in RenderBox.cpp and also
remove computation for margins on table since table does not support margins from layout function.

* Source/WebCore/rendering/RenderTableRow.cpp:
(RenderTableRow::layout): Remove 'computeAndSetBlockDirectionMargins' since table does not support margins
* Source/WebCore/rendering/RenderBox.cpp:
(RenderBox::availableLogicalHeightUsing): Remove FIXME and related code and change with ASSERT

Canonical link: https://commits.webkit.org/259955@main




More information about the webkit-changes mailing list