[webkit-changes] [WebKit/WebKit] ce3b36: Introduce SWServer delegates

youennf noreply at github.com
Tue Feb 7 00:18:29 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ce3b36c624c0bf0f92f1be2cc8219ec68a50bd2c
      https://github.com/WebKit/WebKit/commit/ce3b36c624c0bf0f92f1be2cc8219ec68a50bd2c
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2023-02-07 (Tue, 07 Feb 2023)

  Changed paths:
    M Source/WebCore/Headers.cmake
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/workers/service/server/SWServer.cpp
    M Source/WebCore/workers/service/server/SWServer.h
    A Source/WebCore/workers/service/server/SWServerDelegate.h
    M Source/WebKit/NetworkProcess/NetworkSession.cpp
    M Source/WebKit/NetworkProcess/NetworkSession.h
    M Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerSoftUpdateLoader.cpp
    M Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerSoftUpdateLoader.h

  Log Message:
  -----------
  Introduce SWServer delegates
https://bugs.webkit.org/show_bug.cgi?id=251776
rdar://problem/105071414

Reviewed by Chris Dumez.

We have many delegates as callbacks and might be adding more in the future.
Let's move the callbacks to a delegate class as it is more convenient.
Small ServiceWorkerSoftUpdateLoader refactoring to use a regular constructor.

* Source/WebCore/Headers.cmake:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/workers/service/server/SWServer.cpp:
(WebCore::SWServer::SWServer):
(WebCore::SWServer::validateRegistrationDomain):
(WebCore::SWServer::startScriptFetch):
(WebCore::SWServer::refreshImportedScripts):
(WebCore::SWServer::tryInstallContextData):
(WebCore::SWServer::contextConnectionCreated):
(WebCore::SWServer::createContextConnection):
* Source/WebCore/workers/service/server/SWServer.h:
* Source/WebCore/workers/service/server/SWServerDelegate.h: Added.
* Source/WebKit/NetworkProcess/NetworkSession.cpp:
(WebKit::NetworkSession::ensureSWServer):
(WebKit::NetworkSession::softUpdate):
(WebKit::NetworkSession::createContextConnection):
(WebKit::NetworkSession::appBoundDomains):
(WebKit::NetworkSession::addAllowedFirstPartyForCookies):
* Source/WebKit/NetworkProcess/NetworkSession.h:
* Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerSoftUpdateLoader.cpp:
(WebKit::ServiceWorkerSoftUpdateLoader::start): Deleted.
* Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerSoftUpdateLoader.h:

Canonical link: https://commits.webkit.org/259942@main




More information about the webkit-changes mailing list