[webkit-changes] [WebKit/WebKit] c11d33: AX: Object IDs should not be generated with AXTree...

[AndresGonzalezApple]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c11d33bb0bb2029b58e6fd830fc9cab2d7630d64
      https://github.com/WebKit/WebKit/commit/c11d33bb0bb2029b58e6fd830fc9cab2d7630d64
  Author: Andres Gonzalez <andresg_22 at apple.com>
  Date:   2023-02-06 (Mon, 06 Feb 2023)

  Changed paths:
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/accessibility/AXObjectCache.h

  Log Message:
  -----------
  AX: Object IDs should not be generated with AXTreeStore::generateNewID().
https://bugs.webkit.org/show_bug.cgi?id=251577
<rdar://problem/104956200>

Reviewed by Chris Fleizach.

In the patch for
    https://bugs.webkit.org/show_bug.cgi?id=249480
    <rdar://problem/103449294>

I erroneously switched the generation of object IDS in the AXObjectCache to use AXTreeStore::generateNewID. This is wrong because generateNewID checks the presence of the ID against the IDs of AX trees and not against object IDs. This patch rectifies this by bringing back AXObjectCache::generateNewObjectID (new name).

* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::generateNewObjectID const):
(WebCore::AXObjectCache::getAXID):
* Source/WebCore/accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::objectForID const): No need to pass AXID by reference since it just wraps an unsgined.

Canonical link: https://commits.webkit.org/259922@main