[webkit-changes] [WebKit/WebKit] bd3543: Reduce build times by refactoring JSDOMGlobalObject.h

Jer Noble noreply at github.com
Mon Feb 6 10:39:46 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bd35435fc6d728ae3c5c185df96264d86160c5bd
      https://github.com/WebKit/WebKit/commit/bd35435fc6d728ae3c5c185df96264d86160c5bd
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2023-02-06 (Mon, 06 Feb 2023)

  Changed paths:
    M Source/WebCore/bindings/js/JSDOMAttribute.h
    M Source/WebCore/bindings/js/JSDOMGlobalObject.cpp
    M Source/WebCore/bindings/js/JSDOMGlobalObject.h
    M Source/WebCore/bindings/js/JSDOMGlobalObjectInlines.h
    M Source/WebCore/bindings/js/JSDOMGuardedObject.cpp
    M Source/WebCore/bindings/js/JSDOMMapLike.cpp
    M Source/WebCore/bindings/js/JSDOMSetLike.cpp
    M Source/WebCore/bindings/js/JSDOMWindowCustom.cpp
    M Source/WebCore/bindings/js/JSDocumentCustom.cpp
    M Source/WebCore/bindings/js/JSEventTargetCustom.cpp
    M Source/WebCore/bindings/js/JSNavigatorCustom.cpp
    M Source/WebCore/bindings/js/JSValueInWrappedObject.h
    M Source/WebCore/bindings/js/ReadableStream.cpp
    M Source/WebCore/inspector/CommandLineAPIModule.cpp

  Log Message:
  -----------
  Reduce build times by refactoring JSDOMGlobalObject.h
https://bugs.webkit.org/show_bug.cgi?id=251570
rdar://104949069

Reviewed by Ryosuke Niwa.

Move inline methods into JSDOMGlobalObjectInlines.h, and add that include to all source files
where those inlines are used.

Allow JSBuiltinInternalFunctions to be forward declared by putting the m_builtinInternalFunctions
in a UniqueRef rather than a bare object.

Fix some drive-by build errors revealed by removing inline headers from JSDOMGlobalObject.h.

Canonical link: https://commits.webkit.org/259903@main




More information about the webkit-changes mailing list