[webkit-changes] [WebKit/WebKit] 9354d9: Remove unnecessary masking after wasm LLInt compar...

Commit Queue noreply at github.com
Mon Feb 6 01:15:59 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9354d948240f4a6f2461eaf6a3febaa3424f0967
      https://github.com/WebKit/WebKit/commit/9354d948240f4a6f2461eaf6a3febaa3424f0967
  Author: Mark Lam <mark.lam at apple.com>
  Date:   2023-02-06 (Mon, 06 Feb 2023)

  Changed paths:
    M Source/JavaScriptCore/llint/WebAssembly.asm
    M Source/JavaScriptCore/llint/WebAssembly32_64.asm
    M Source/JavaScriptCore/llint/WebAssembly64.asm

  Log Message:
  -----------
  Remove unnecessary masking after wasm LLInt comparison instructions.
https://bugs.webkit.org/show_bug.cgi?id=251769
rdar://105063662

Reviewed by Tadeu Zagallo.

Currently, we always follow a LLInt comparison instructions with an `and with 1` mask.
This is completely unnecessary because the LLInt comparison instructions already always
produce a 1 or a 0.  Hence, the `and with 1` mask is effectively a no-op.  This patch
removes this unnecessary masking.

* Source/JavaScriptCore/llint/WebAssembly.asm:
* Source/JavaScriptCore/llint/WebAssembly32_64.asm:
* Source/JavaScriptCore/llint/WebAssembly64.asm:

Canonical link: https://commits.webkit.org/259882@main




More information about the webkit-changes mailing list