[webkit-changes] [WebKit/WebKit] 9bc94b: [GPU Process] [FormControls] Share the ApplePayBut...

[Said Abou-Hallawa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9bc94b5f4fb6121f2f0fb01688a2f596aa76324f
      https://github.com/WebKit/WebKit/commit/9bc94b5f4fb6121f2f0fb01688a2f596aa76324f
  Author: Said Abou-Hallawa <said at apple.com>
  Date:   2023-02-05 (Sun, 05 Feb 2023)

  Changed paths:
    M Source/WebCore/Headers.cmake
    R Source/WebCore/Modules/applepay/ApplePayButtonSystemImage.h
    R Source/WebCore/Modules/applepay/ApplePayButtonSystemImage.mm
    M Source/WebCore/SourcesCocoa.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/css/CSSPrimitiveValueMappings.h
    M Source/WebCore/platform/graphics/SystemImage.h
    M Source/WebCore/platform/graphics/cocoa/controls/ApplePayButtonCocoa.mm
    M Source/WebCore/platform/graphics/controls/ApplePayButtonPart.h
    M Source/WebCore/platform/graphics/controls/ControlFactory.cpp
    A Source/WebCore/platform/graphics/ios/controls/ControlFactoryIOS.h
    A Source/WebCore/platform/graphics/ios/controls/ControlFactoryIOS.mm
    M Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.h
    M Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.mm
    M Source/WebCore/platform/graphics/mac/controls/ToggleButtonMac.mm
    M Source/WebCore/rendering/RenderTheme.cpp
    M Source/WebCore/rendering/RenderThemeCocoa.h
    M Source/WebCore/rendering/RenderThemeCocoa.mm
    M Source/WebCore/rendering/RenderThemeIOS.h
    M Source/WebCore/rendering/RenderThemeIOS.mm
    M Source/WebCore/rendering/style/RenderStyle.h
    M Source/WebKit/Shared/WebCoreArgumentCoders.cpp
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in

  Log Message:
  -----------
  [GPU Process] [FormControls] Share the ApplePayButton drawing among all Cocoa platforms
https://bugs.webkit.org/show_bug.cgi?id=251708
rdar://105020333

Reviewed by Aditya Keerthi.

Remove RenderThemeCocoa::paintApplePayButton() and create a ControlPart for the
ApplePayButton on iOS so it can be drawn by ApplePayButtonCocoa::draw().

Add a ControlFactory for iOS and add stub creators for the platform controls.
These creators will be filled in the future to replace the existing code in
RenderThemeIOS with iOS platform controls.

* Source/WebCore/Headers.cmake:
* Source/WebCore/Modules/applepay/ApplePayButtonSystemImage.h: Removed.
* Source/WebCore/Modules/applepay/ApplePayButtonSystemImage.mm: Removed.
* Source/WebCore/SourcesCocoa.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/css/CSSPrimitiveValueMappings.h:
* Source/WebCore/platform/graphics/SystemImage.h:
* Source/WebCore/platform/graphics/cocoa/controls/ApplePayButtonCocoa.mm:
(WebCore::toPKPaymentButtonType):
(WebCore::toPKPaymentButtonStyle):
(WebCore::ApplePayButtonCocoa::draw):
* Source/WebCore/platform/graphics/controls/ApplePayButtonPart.h:
* Source/WebCore/platform/graphics/controls/ControlFactory.cpp:
* Source/WebCore/platform/graphics/ios/controls/ControlFactoryIOS.h: Added.
* Source/WebCore/platform/graphics/ios/controls/ControlFactoryIOS.mm: Added.
(WebCore::ControlFactory::createControlFactory):
(WebCore::ControlFactoryIOS::createPlatformButton):
(WebCore::ControlFactoryIOS::createPlatformColorWell):
(WebCore::ControlFactoryIOS::createPlatformInnerSpinButton):
(WebCore::ControlFactoryIOS::createPlatformMenuList):
(WebCore::ControlFactoryIOS::createPlatformMenuListButton):
(WebCore::ControlFactoryIOS::createPlatformMeter):
(WebCore::ControlFactoryIOS::createPlatformProgressBar):
(WebCore::ControlFactoryIOS::createPlatformSearchField):
(WebCore::ControlFactoryIOS::createPlatformSearchFieldCancelButton):
(WebCore::ControlFactoryIOS::createPlatformSearchFieldResults):
(WebCore::ControlFactoryIOS::createPlatformSliderThumb):
(WebCore::ControlFactoryIOS::createPlatformSliderTrack):
(WebCore::ControlFactoryIOS::createPlatformTextArea):
(WebCore::ControlFactoryIOS::createPlatformTextField):
(WebCore::ControlFactoryIOS::createPlatformToggleButton):
* Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.h:
* Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.mm:
* Source/WebCore/platform/graphics/mac/controls/ToggleButtonMac.mm:
* Source/WebCore/rendering/RenderTheme.cpp:
* Source/WebCore/rendering/RenderThemeCocoa.h:
* Source/WebCore/rendering/RenderThemeCocoa.mm:
(WebCore::RenderThemeCocoa::paintApplePayButton): Deleted.
* Source/WebCore/rendering/RenderThemeIOS.h:
* Source/WebCore/rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::canCreateControlPartForRenderer const):
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebKit/Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<SystemImage>::encode):
(IPC::ArgumentCoder<SystemImage>::decode):
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/259878@main