[webkit-changes] [WebKit/WebKit] 69938d: [macOS] Running layout tests in fast/forms leaves ...

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 69938dbb05fd766cad432e3662201f33485eaf39
      https://github.com/WebKit/WebKit/commit/69938dbb05fd766cad432e3662201f33485eaf39
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2023-02-05 (Sun, 05 Feb 2023)

  Changed paths:
    M Tools/WebKitTestRunner/mac/TestControllerMac.mm

  Log Message:
  -----------
  [macOS] Running layout tests in fast/forms leaves a popup visible in the top left of the window, breaking all typing
https://bugs.webkit.org/show_bug.cgi?id=251740
rdar://104719873

Reviewed by Wenson Hsieh.

226753 at main began swizzling methods on `NSMenu` and `NSCarbonMenuImpl` so that
tests that present system popups could be run simultaneously. To support this
behavior, layout tests never actually present popup menus. However, the class
of the underlying menu implementation is configuration dependent. This means
that the correct method is not always swizzled, resulting in popups being
presented unexpectedly.

To fix, obtain the underlying menu implementation at runtime, ensuring that
the correct method is swizzled.

* Tools/WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::menuImplClass):
(WTR::TestController::platformInitialize):

Canonical link: https://commits.webkit.org/259872@main